[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-05-04 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15271156#comment-15271156 ] Xiaoyu Yao commented on HDFS-10324: --- Thanks [~jojochuang] for updating the patch. The patch looks good

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-05-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15269807#comment-15269807 ] Hadoop QA commented on HDFS-10324: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-05-02 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15268138#comment-15268138 ] Hadoop QA commented on HDFS-10324: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-05-02 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267959#comment-15267959 ] Xiaoyu Yao commented on HDFS-10324: --- Thanks [~andrew.wang] and [~jojochuang]. HDFS-10344 is for a

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-05-02 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267848#comment-15267848 ] Wei-Chiu Chuang commented on HDFS-10324: Yeah I didn't do that. I was under the impression Xiaoyu

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-05-02 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15267828#comment-15267828 ] Andrew Wang commented on HDFS-10324: Thanks Wei-Chiu, LGTM overall. I think this is ready for commit,

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-28 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15262700#comment-15262700 ] Wei-Chiu Chuang commented on HDFS-10324: Thanks Xiaoyu and Andrew. I'm currently per-occupied by

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-27 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15261263#comment-15261263 ] Andrew Wang commented on HDFS-10324: Sounds good to me [~xyao]. Let's also do the provisionTrash flag

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-26 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259311#comment-15259311 ] Xiaoyu Yao commented on HDFS-10324: --- Thanks [~andrew.wang] and [~jojochuang]. I agree with you analysis

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-26 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259231#comment-15259231 ] Andrew Wang commented on HDFS-10324: Thanks for the discussion all, and Wei-Chiu for the patch.

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-26 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259195#comment-15259195 ] Wei-Chiu Chuang commented on HDFS-10324: It is true that this API is used only in unit tests in

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-26 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15259118#comment-15259118 ] Xiaoyu Yao commented on HDFS-10324: --- Thanks [~jojochuang] for update the patch. The patch v003 looks

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-26 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257766#comment-15257766 ] Wei-Chiu Chuang commented on HDFS-10324: Failed tests are known, flaky tests reported in

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15257593#comment-15257593 ] Hadoop QA commented on HDFS-10324: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-25 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256742#comment-15256742 ] Xiaoyu Yao commented on HDFS-10324: --- Thanks [~andrew.wang] for the comments. I agree it is important to

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-25 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1525#comment-1525 ] Andrew Wang commented on HDFS-10324: I'm somewhat concerned about the compatibility issues of

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256657#comment-15256657 ] Hadoop QA commented on HDFS-10324: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-25 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256633#comment-15256633 ] Xiaoyu Yao commented on HDFS-10324: --- [~jojochuang], I mentioned #2 because Trash is client feature that

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-25 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256569#comment-15256569 ] Wei-Chiu Chuang commented on HDFS-10324: Thanks [~xyao] for the comments. Regarding #1, I don't

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-25 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15256505#comment-15256505 ] Xiaoyu Yao commented on HDFS-10324: --- Thanks [~jojochuang] for updating the patch. Here are a few

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-22 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254478#comment-15254478 ] Andrew Wang commented on HDFS-10324: Yes, that's why I suggested adding a new flag on {{hdfs crypto

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-22 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254363#comment-15254363 ] Wei-Chiu Chuang commented on HDFS-10324: Also, if a directory is initialized as an EZ and a

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-22 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254328#comment-15254328 ] Andrew Wang commented on HDFS-10324: Does this work when the EZ root is not writable by the

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-22 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254304#comment-15254304 ] Wei-Chiu Chuang commented on HDFS-10324: Cool! Thanks Xiaoyu. I initially had the similar fix, but

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-22 Thread Xiaoyu Yao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15254284#comment-15254284 ] Xiaoyu Yao commented on HDFS-10324: --- Thanks [~jojochuang] for reporting the issue and posting the patch

[jira] [Commented] (HDFS-10324) Trash directory in an encryption zone should be pre-created with sticky bit

2016-04-22 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-10324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15253459#comment-15253459 ] Andrew Wang commented on HDFS-10324: Not sure about this one. It doesn't handle existing EZs from an