[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15373931#comment-15373931
]
Kai Zheng commented on HDFS-10548:
--
Thanks Steve for the sync up ...
> Remove the long deprecated
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15370549#comment-15370549
]
Steve Loughran commented on HDFS-10548:
---
I have no opinions; Chris is on vacation this week, so best
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363678#comment-15363678
]
Kai Zheng commented on HDFS-10548:
--
bq. Is there a JIRA for removing BRLocalLegacy too? IIRC Windows used
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363584#comment-15363584
]
Andrew Wang commented on HDFS-10548:
I think what Colin meant is that (with the rename) if someone
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363555#comment-15363555
]
Kai Zheng commented on HDFS-10548:
--
This was done targeting 3.0, but if we need this for branch-2 as
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363549#comment-15363549
]
Andrew Wang commented on HDFS-10548:
I don't think there's too much activity on BlockReaderRemote2
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15363003#comment-15363003
]
Colin Patrick McCabe commented on HDFS-10548:
-
Thanks for tackling this, guys. It is good to
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359970#comment-15359970
]
Hudson commented on HDFS-10548:
---
SUCCESS: Integrated in Hadoop-trunk-Commit #10047 (See
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15359780#comment-15359780
]
Andrew Wang commented on HDFS-10548:
SGTM, feel free to commit Kai. +1.
> Remove the long deprecated
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15356268#comment-15356268
]
Kai Zheng commented on HDFS-10548:
--
Thanks [~andrew.wang] for the reviewing! The only check style isn't
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355702#comment-15355702
]
Hadoop QA commented on HDFS-10548:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355544#comment-15355544
]
Andrew Wang commented on HDFS-10548:
To be clear, +1 pending the precommit run :)
> Remove the long
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15355542#comment-15355542
]
Andrew Wang commented on HDFS-10548:
LGTM, thanks Kai! I kicked the precommit build so we can test the
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354471#comment-15354471
]
Hadoop QA commented on HDFS-10548:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354084#comment-15354084
]
Kai Zheng commented on HDFS-10548:
--
Updated the patch doing the rename and also cleaning up the related
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354000#comment-15354000
]
Kai Zheng commented on HDFS-10548:
--
Sure, Andrew! I will do that shortly.
> Remove the long deprecated
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15353935#comment-15353935
]
Andrew Wang commented on HDFS-10548:
Hi Kai, do you want to also rename BlockReaderRemote2 to just
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341480#comment-15341480
]
Hadoop QA commented on HDFS-10548:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15341341#comment-15341341
]
Kai Zheng commented on HDFS-10548:
--
Thanks Colin for the nice comment. I checked the old class again and
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15340836#comment-15340836
]
Colin Patrick McCabe commented on HDFS-10548:
-
I would love to see this class go away. It is
[
https://issues.apache.org/jira/browse/HDFS-10548?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15338879#comment-15338879
]
Kai Zheng commented on HDFS-10548:
--
[~cmccabe], how would you like this if we do it targeting the 3.0
21 matches
Mail list logo
