[jira] [Commented] (HDFS-10620) StringBuilder created and appended even if logging is disabled

[ https://issues.apache.org/jira/browse/HDFS-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883339#comment-15883339 ] John Zhuge commented on HDFS-10620: --- +1 LGTM :) > StringBuilder created and appended even if logging

[jira] [Commented] (HDFS-10620) StringBuilder created and appended even if logging is disabled

[ https://issues.apache.org/jira/browse/HDFS-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15883306#comment-15883306 ] Akira Ajisaka commented on HDFS-10620: -- Hi [~jzhuge], would you give binding +1 for the patch? >

[jira] [Commented] (HDFS-10620) StringBuilder created and appended even if logging is disabled

[ https://issues.apache.org/jira/browse/HDFS-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15866646#comment-15866646 ] John Zhuge commented on HDFS-10620: --- +1 (non-binding) on {{HDFS-10620-branch-2.01.patch}}. Sorry I

[jira] [Commented] (HDFS-10620) StringBuilder created and appended even if logging is disabled

[ https://issues.apache.org/jira/browse/HDFS-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15865461#comment-15865461 ] Akira Ajisaka commented on HDFS-10620: -- Hi [~jzhuge], would you check the patch for branch-2? >

[jira] [Commented] (HDFS-10620) StringBuilder created and appended even if logging is disabled

[ https://issues.apache.org/jira/browse/HDFS-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15806350#comment-15806350 ] Hadoop QA commented on HDFS-10620: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-10620) StringBuilder created and appended even if logging is disabled

[ https://issues.apache.org/jira/browse/HDFS-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393254#comment-15393254 ] Hadoop QA commented on HDFS-10620: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-10620) StringBuilder created and appended even if logging is disabled

[ https://issues.apache.org/jira/browse/HDFS-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393059#comment-15393059 ] Akira Ajisaka commented on HDFS-10620: -- Reverted. Thanks [~jzhuge]! I'll upload a patch for the

[jira] [Commented] (HDFS-10620) StringBuilder created and appended even if logging is disabled

[ https://issues.apache.org/jira/browse/HDFS-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393056#comment-15393056 ] Akira Ajisaka commented on HDFS-10620: -- Thank you for the comment. I'll revert this commit from

[jira] [Commented] (HDFS-10620) StringBuilder created and appended even if logging is disabled

[ https://issues.apache.org/jira/browse/HDFS-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15393046#comment-15393046 ] John Zhuge commented on HDFS-10620: --- Hi [~ajisakaa], when you merged the fix to branch-2 and branch-2.8,

[jira] [Commented] (HDFS-10620) StringBuilder created and appended even if logging is disabled

[ https://issues.apache.org/jira/browse/HDFS-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383485#comment-15383485 ] Akira Ajisaka commented on HDFS-10620: -- +1 for the 002 patch. I ran the failed tests locally and all

[jira] [Commented] (HDFS-10620) StringBuilder created and appended even if logging is disabled

[ https://issues.apache.org/jira/browse/HDFS-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383454#comment-15383454 ] Hadoop QA commented on HDFS-10620: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-10620) StringBuilder created and appended even if logging is disabled

[ https://issues.apache.org/jira/browse/HDFS-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383187#comment-15383187 ] Akira Ajisaka commented on HDFS-10620: -- I'm in favor of the latter patch to avoid creating

[jira] [Commented] (HDFS-10620) StringBuilder created and appended even if logging is disabled

[ https://issues.apache.org/jira/browse/HDFS-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375945#comment-15375945 ] Hadoop QA commented on HDFS-10620: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-10620) StringBuilder created and appended even if logging is disabled

[ https://issues.apache.org/jira/browse/HDFS-10620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375756#comment-15375756 ] Staffan Friberg commented on HDFS-10620: To avoid all allocation. {noformat} diff --git