[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15541287#comment-15541287
]
Fenghua Hu commented on HDFS-10690:
---
Failed case has nothing to do with the patch, and they also passed
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15540714#comment-15540714
]
Hadoop QA commented on HDFS-10690:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15538643#comment-15538643
]
Hadoop QA commented on HDFS-10690:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537690#comment-15537690
]
Hadoop QA commented on HDFS-10690:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15537580#comment-15537580
]
Fenghua Hu commented on HDFS-10690:
---
Hi [~xyao], I should had run a clean compilation, sorry for your
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15536651#comment-15536651
]
Xiaoyu Yao commented on HDFS-10690:
---
[~fenghua_hu], we will need to update
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15533068#comment-15533068
]
Fenghua Hu commented on HDFS-10690:
---
[~stack] thanks for reviewing the patch!
> Optimize
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15531228#comment-15531228
]
stack commented on HDFS-10690:
--
Skimmed. Patch LGTM. Unfortunate we leave behind some perf but agree on
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15531057#comment-15531057
]
Fenghua Hu commented on HDFS-10690:
---
[~xyao], thanks for the help!
> Optimize insertion/removal of
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15530221#comment-15530221
]
Xiaoyu Yao commented on HDFS-10690:
---
[~fenghua_hu]: the patch v06 looks good. I plan to commit it by EOD
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528584#comment-15528584
]
Fenghua Hu commented on HDFS-10690:
---
This fix doesn't change any interface, and I have run the unit test
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528355#comment-15528355
]
Hadoop QA commented on HDFS-10690:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15528033#comment-15528033
]
Fenghua Hu commented on HDFS-10690:
---
looks like patch v6 hasn't been built and verified by Jenkins.
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15525167#comment-15525167
]
Xiaoyu Yao commented on HDFS-10690:
---
Thanks [~fenghua_hu] for updating the patch. +1 for patch v6
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524750#comment-15524750
]
Fenghua Hu commented on HDFS-10690:
---
Removed unnessary "if (eldestKey == null)" statement, and updated
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15524699#comment-15524699
]
Fenghua Hu commented on HDFS-10690:
---
Thanks [~xyao] for your suggestion. How about we just remove "if
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15523763#comment-15523763
]
Xiaoyu Yao commented on HDFS-10690:
---
[~fenghua_hu], thanks for updating the patch. The patch v05 looks
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522171#comment-15522171
]
Hadoop QA commented on HDFS-10690:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522107#comment-15522107
]
Fenghua Hu commented on HDFS-10690:
---
Existing unit tests have been able to cover all the necessary
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15522047#comment-15522047
]
Hadoop QA commented on HDFS-10690:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521976#comment-15521976
]
Hadoop QA commented on HDFS-10690:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15521943#comment-15521943
]
Fenghua Hu commented on HDFS-10690:
---
hi [~xyao], based on your suggestion, i have updated the patch
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15490754#comment-15490754
]
Xiaoyu Yao commented on HDFS-10690:
---
Thanks [~fenghua_hu] for providing the new numbers. Considering the
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15484232#comment-15484232
]
Fenghua Hu commented on HDFS-10690:
---
[~xyao],
I just got environment to test your patch. Below is the
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434094#comment-15434094
]
Xiaoyu Yao commented on HDFS-10690:
---
I mean the LinkedMap patch should just work without revision.
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15434077#comment-15434077
]
Fenghua Hu commented on HDFS-10690:
---
I got you. I'll run YCSB.
Regarding the patch, what do you mean "I
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433988#comment-15433988
]
Xiaoyu Yao commented on HDFS-10690:
---
bq. I'll write a micro benchmark to compare LinkedMap with TreeMap
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433918#comment-15433918
]
Fenghua Hu commented on HDFS-10690:
---
[~xyao], thanks for your comments. I'll write a micro benchmark to
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433269#comment-15433269
]
Xiaoyu Yao commented on HDFS-10690:
---
[~fenghua_hu], I understand the tradeoff between memory footprint
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15433142#comment-15433142
]
Fenghua Hu commented on HDFS-10690:
---
I would like to explain the solution here.
Currently, TreeMap is
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423714#comment-15423714
]
Fenghua Hu commented on HDFS-10690:
---
[~xyao],
Thanks for your support!
I would like to clarify that
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15423197#comment-15423197
]
Xiaoyu Yao commented on HDFS-10690:
---
Thanks [~fenghua_hu] for correcting the mix usage of index/key in
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15420579#comment-15420579
]
Fenghua Hu commented on HDFS-10690:
---
[~xyao], I have a question about the patch:
According to
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15416326#comment-15416326
]
Fenghua Hu commented on HDFS-10690:
---
Xiaoyu,
[~xyao]Thanks for the suggestion. I'll test the patch once
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415586#comment-15415586
]
Hadoop QA commented on HDFS-10690:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15415563#comment-15415563
]
Xiaoyu Yao commented on HDFS-10690:
---
bq. I tried to replace TreeMap with linkedHashMap, but found
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15413040#comment-15413040
]
Yu Li commented on HDFS-10690:
--
{quote}
Run GET queries with 64 YCSB processes for 30 minutes, record the QPS
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407012#comment-15407012
]
Fenghua Hu commented on HDFS-10690:
---
Xiaoyu,
[~xiaoyuyao] I tried to replace TreeMap with
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15400336#comment-15400336
]
Fenghua Hu commented on HDFS-10690:
---
Xiaoyu, thanks for the reply. Regarding the bulletin 2, look like i
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15399796#comment-15399796
]
Xiaoyu Yao commented on HDFS-10690:
---
[~fenghua_hu], thanks for updating the patch with the perf numbers.
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398939#comment-15398939
]
Fenghua Hu commented on HDFS-10690:
---
Performance test result against hadoop-2.6.4:
Test configuration:
*
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398899#comment-15398899
]
Hadoop QA commented on HDFS-10690:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398762#comment-15398762
]
Fenghua Hu commented on HDFS-10690:
---
Patch updated.
> Optimize insertion/removal of replica in
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15398429#comment-15398429
]
Fenghua Hu commented on HDFS-10690:
---
Xiaoyu, thanks for the suggestion. LinkedHashMap is another good
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397871#comment-15397871
]
Xiaoyu Yao commented on HDFS-10690:
---
[~fenghua_hu], thanks for reporting the issue and posting the fix.
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397805#comment-15397805
]
Hadoop QA commented on HDFS-10690:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397798#comment-15397798
]
Hadoop QA commented on HDFS-10690:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-10690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15397637#comment-15397637
]
Fenghua Hu commented on HDFS-10690:
---
Some comments about the patch:
1. LruList.java implements a
48 matches
Mail list logo
