[jira] [Commented] (HDFS-11210) Enhance key rolling to guarantee new KeyVersion is returned from generateEncryptedKeys after a key is rolled

2017-02-07 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857453#comment-15857453 ] Hudson commented on HDFS-11210: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11221 (See

[jira] [Commented] (HDFS-11210) Enhance key rolling to guarantee new KeyVersion is returned from generateEncryptedKeys after a key is rolled

2017-02-07 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857241#comment-15857241 ] Xiao Chen commented on HDFS-11210: -- Thanks a lot Andrew! Test failure look unrelated and passes locally.

[jira] [Commented] (HDFS-11210) Enhance key rolling to guarantee new KeyVersion is returned from generateEncryptedKeys after a key is rolled

2017-02-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857151#comment-15857151 ] Hadoop QA commented on HDFS-11210: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-11210) Enhance key rolling to guarantee new KeyVersion is returned from generateEncryptedKeys after a key is rolled

2017-02-07 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857085#comment-15857085 ] Andrew Wang commented on HDFS-11210: Gotcha, I figured it was related to negative numbers, though my

[jira] [Commented] (HDFS-11210) Enhance key rolling to guarantee new KeyVersion is returned from generateEncryptedKeys after a key is rolled

2017-02-07 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857057#comment-15857057 ] Xiao Chen commented on HDFS-11210: -- Thanks Andrew, if you have any other comments, please don't hold

[jira] [Commented] (HDFS-11210) Enhance key rolling to guarantee new KeyVersion is returned from generateEncryptedKeys after a key is rolled

2017-02-07 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857016#comment-15857016 ] Andrew Wang commented on HDFS-11210: LGTM overall, I think we can just commit this as is if you want.

[jira] [Commented] (HDFS-11210) Enhance key rolling to guarantee new KeyVersion is returned from generateEncryptedKeys after a key is rolled

2017-02-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15856002#comment-15856002 ] Hadoop QA commented on HDFS-11210: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-11210) Enhance key rolling to guarantee new KeyVersion is returned from generateEncryptedKeys after a key is rolled

2017-02-07 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15855645#comment-15855645 ] Xiao Chen commented on HDFS-11210: -- Thanks a lot for the review Andrew! Exactly the 'quality review' I

[jira] [Commented] (HDFS-11210) Enhance key rolling to guarantee new KeyVersion is returned from generateEncryptedKeys after a key is rolled

2017-02-03 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852474#comment-15852474 ] Andrew Wang commented on HDFS-11210: Thanks for the rev Xiao, looks pretty close, mostly nitty stuff

[jira] [Commented] (HDFS-11210) Enhance key rolling to guarantee new KeyVersion is returned from generateEncryptedKeys after a key is rolled

2017-02-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-11210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15848245#comment-15848245 ] Hadoop QA commented on HDFS-11210: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||