[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15958034#comment-15958034
]
Andrew Wang commented on HDFS-11395:
I backported this to branch-2.8 to make another backport easier,
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923520#comment-15923520
]
Nandakumar commented on HDFS-11395:
---
Thanks [~arpitagarwal] & [~jingzhao] for the reviews and commit.
>
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15923027#comment-15923027
]
Hudson commented on HDFS-11395:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11397 (See
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922957#comment-15922957
]
Jing Zhao commented on HDFS-11395:
--
+1. I will commit the patch shortly.
>
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905949#comment-15905949
]
Arpit Agarwal commented on HDFS-11395:
--
[~jingzhao], are you +1 for this patch?
>
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15905099#comment-15905099
]
Nandakumar commented on HDFS-11395:
---
Test case failures are not related to this patch.
>
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15904093#comment-15904093
]
Hadoop QA commented on HDFS-11395:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15903846#comment-15903846
]
Arpit Agarwal commented on HDFS-11395:
--
Kicked off another pre-commit run:
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899906#comment-15899906
]
Jing Zhao commented on HDFS-11395:
--
hmmm looks like the testing node has not got fixed yet...
>
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15899900#comment-15899900
]
Jing Zhao commented on HDFS-11395:
--
The 005 patch looks good to me. Let me trigger the Jenkins.
>
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897897#comment-15897897
]
Nandakumar commented on HDFS-11395:
---
Thanks [~jingzhao], review comments have be incorporated in
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15897830#comment-15897830
]
Jing Zhao commented on HDFS-11395:
--
The 004 patch looks good to me. Just some minors:
# Here since we're
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895929#comment-15895929
]
Hadoop QA commented on HDFS-11395:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895903#comment-15895903
]
Nandakumar commented on HDFS-11395:
---
[^HDFS-11395.004.patch]: checkstyle corrected.
>
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895895#comment-15895895
]
Hadoop QA commented on HDFS-11395:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895839#comment-15895839
]
Nandakumar commented on HDFS-11395:
---
Thanks for the review [~jingzhao].
The following review comments
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15895004#comment-15895004
]
Hadoop QA commented on HDFS-11395:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894925#comment-15894925
]
Jing Zhao commented on HDFS-11395:
--
Thanks for updating the patch, [~nandakumar131]. Some further
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15894755#comment-15894755
]
Nandakumar commented on HDFS-11395:
---
In [^HDFS-11395.002.patch],
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15893227#comment-15893227
]
Jing Zhao commented on HDFS-11395:
--
bq. in case of non RemoteException from ExecutionException, what
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15891553#comment-15891553
]
Nandakumar commented on HDFS-11395:
---
Thanks for the review [~jingzhao].
I agree, we should not simply
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15890867#comment-15890867
]
Jing Zhao commented on HDFS-11395:
--
Thanks for working on this, [~nandakumar131]. I agree we should not
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1559#comment-1559
]
Hadoop QA commented on HDFS-11395:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15888565#comment-15888565
]
Nandakumar commented on HDFS-11395:
---
[~arpitagarwal], based on the suggestions/comments new patch is
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15882332#comment-15882332
]
Nandakumar commented on HDFS-11395:
---
Thanks for the suggestion [~arpitagarwal], I will work on the
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15881058#comment-15881058
]
Arpit Agarwal commented on HDFS-11395:
--
bq. Is there any other check that can be performed to
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15880162#comment-15880162
]
Nandakumar commented on HDFS-11395:
---
{quote}
Deciding what to do when we get a MultiException should
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15878972#comment-15878972
]
Arpit Agarwal commented on HDFS-11395:
--
Hi [~nandakumar131], RetryInvocationHandler has some logic
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15877571#comment-15877571
]
Nandakumar commented on HDFS-11395:
---
Thanks for the review [~arpitagarwal].
The HDFS clients expect
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876930#comment-15876930
]
Arpit Agarwal commented on HDFS-11395:
--
Thanks for reporting this [~nanda131].
Short-circuiting the
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15873777#comment-15873777
]
Hadoop QA commented on HDFS-11395:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15867248#comment-15867248
]
Nandakumar commented on HDFS-11395:
---
In [^HDFS-11395.000.patch], if
[
https://issues.apache.org/jira/browse/HDFS-11395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857689#comment-15857689
]
Nandakumar commented on HDFS-11395:
---
If we get RemoteException other than {{StandbyException}}, it is
33 matches
Mail list logo
