[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-09-06 Thread Adam Whitlock (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156149#comment-16156149 ] Adam Whitlock commented on HDFS-12131: -- [~shv] and [~xkrogen] - Thank you! > Add some of the

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-09-06 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156146#comment-16156146 ] Erik Krogen commented on HDFS-12131: Thank you Konstantin! > Add some of the FSNamesystem JMX values

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-09-06 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156097#comment-16156097 ] Konstantin Shvachko commented on HDFS-12131: This is Jenkins run for branch-2.7 patch:

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-09-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156089#comment-16156089 ] Hadoop QA commented on HDFS-12131: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-08-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113661#comment-16113661 ] Hudson commented on HDFS-12131: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12114 (See

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-08-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16113384#comment-16113384 ] Hadoop QA commented on HDFS-12131: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-08-01 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110112#comment-16110112 ] Andrew Wang commented on HDFS-12131: Looks like the patch doesn't apply cleanly to branch-2, mind

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-08-01 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110111#comment-16110111 ] Andrew Wang commented on HDFS-12131: +1 LGTM, thanks Erik! Agree with your comments, no need to do a

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-08-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16110079#comment-16110079 ] Hadoop QA commented on HDFS-12131: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-31 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107978#comment-16107978 ] Andrew Wang commented on HDFS-12131: Sure, let's do the deprecate+removal in separate JIRAs for

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-31 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16107593#comment-16107593 ] Erik Krogen commented on HDFS-12131: Wasn't able to replicate any of the unit test failures locally,

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105756#comment-16105756 ] Hadoop QA commented on HDFS-12131: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105740#comment-16105740 ] Hadoop QA commented on HDFS-12131: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-28 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105527#comment-16105527 ] Erik Krogen commented on HDFS-12131: Okay, that seems fair. Should we have a separate JIRA for fixing

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-28 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105520#comment-16105520 ] Andrew Wang commented on HDFS-12131: The prior example I have of deprecation+removal is HDFS-9024 and

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-28 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105513#comment-16105513 ] Erik Krogen commented on HDFS-12131: Actually, I realized that the Javadoc on MaxObjects is wrong, it

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-28 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16105500#comment-16105500 ] Erik Krogen commented on HDFS-12131: Ah, nice! Looks like you already got the reviews you needed there

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-27 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16104251#comment-16104251 ] Andrew Wang commented on HDFS-12131: I've got a patch out already at HDFS-12206 to fix the

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-27 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16103972#comment-16103972 ] Erik Krogen commented on HDFS-12131: Hey [~andrew.wang], thanks for looking. Here I followed the

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-26 Thread Andrew Wang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16102480#comment-16102480 ] Andrew Wang commented on HDFS-12131: I don't see a downside to exposing these as metrics, thanks for

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16095164#comment-16095164 ] Hadoop QA commented on HDFS-12131: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-20 Thread Rushabh S Shah (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16094888#comment-16094888 ] Rushabh S Shah commented on HDFS-12131: --- +1 non-binding pending jenkins Thanks [~xkrogen]! > Add

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-18 Thread Rushabh S Shah (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091750#comment-16091750 ] Rushabh S Shah commented on HDFS-12131: --- Thanks [~xkrogen] for revising the patch. Overall the patch

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16091017#comment-16091017 ] Hadoop QA commented on HDFS-12131: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-17 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16090769#comment-16090769 ] Erik Krogen commented on HDFS-12131: Ah, thank you for the pointer [~shahrs87]! I was trying to find

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-14 Thread Rushabh S Shah (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16088011#comment-16088011 ] Rushabh S Shah commented on HDFS-12131: --- Thanks [~xkrogen] for the patch. Adding a test case in

[jira] [Commented] (HDFS-12131) Add some of the FSNamesystem JMX values as metrics

2017-07-13 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16086083#comment-16086083 ] Hadoop QA commented on HDFS-12131: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||