[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2018-03-15 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400978#comment-16400978 ] genericqa commented on HDFS-12618: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2018-03-15 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400670#comment-16400670 ] Wellington Chevreuil commented on HDFS-12618: - Any comments on the last patch

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2018-01-05 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312887#comment-16312887 ] Wellington Chevreuil commented on HDFS-12618: - Ain't sure on the *javac* WARN,

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2018-01-04 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312131#comment-16312131 ] genericqa commented on HDFS-12618: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2018-01-04 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311620#comment-16311620 ] Wellington Chevreuil commented on HDFS-12618: - bq. validate() then catch Asser

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2018-01-02 Thread genericqa (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308915#comment-16308915 ] genericqa commented on HDFS-12618: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-12-29 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16306556#comment-16306556 ] Xiao Chen commented on HDFS-12618: -- Sorry for my month-long delay on reviewing, finally l

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-12-07 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16281811#comment-16281811 ] Wellington Chevreuil commented on HDFS-12618: - bq. How is FSDirectory.getINode

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-12-05 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16279130#comment-16279130 ] Daryn Sharp commented on HDFS-12618: This is more of a lament, but HDFS-12811 would ma

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-12-04 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16277482#comment-16277482 ] Wellington Chevreuil commented on HDFS-12618: - I agree with the comments and i

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-11-28 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16269038#comment-16269038 ] Daryn Sharp commented on HDFS-12618: bq. Admittedly snapshot is very complicated and r

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-11-14 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251747#comment-16251747 ] Wellington Chevreuil commented on HDFS-12618: - I'm having problems with append

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-11-10 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248306#comment-16248306 ] Xiao Chen commented on HDFS-12618: -- Yup, append is definitely a valid scenario. We can al

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-11-10 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247872#comment-16247872 ] Wellington Chevreuil commented on HDFS-12618: - bq. Let's please make sure the

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-11-09 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246526#comment-16246526 ] Xiao Chen commented on HDFS-12618: -- Yup, rename is what makes replaces a child inode to b

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-11-09 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16246394#comment-16246394 ] Wellington Chevreuil commented on HDFS-12618: - Thanks [~xiaochen]. Last patch

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-11-08 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16245239#comment-16245239 ] Xiao Chen commented on HDFS-12618: -- Finally managed to review this with more details, tog

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-11-04 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238893#comment-16238893 ] Wellington Chevreuil commented on HDFS-12618: - Thanks [~xiaochen], your last s

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-11-01 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16235007#comment-16235007 ] Xiao Chen commented on HDFS-12618: -- Thanks for the new patch Wellington. >From a quick l

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-10-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16224145#comment-16224145 ] Hadoop QA commented on HDFS-12618: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-10-26 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220685#comment-16220685 ] Daryn Sharp commented on HDFS-12618: bq. I did not -1 on this one because this only h

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-10-26 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220202#comment-16220202 ] Wellington Chevreuil commented on HDFS-12618: - Thanks for the comments [~daryn

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-10-25 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219732#comment-16219732 ] Xiao Chen commented on HDFS-12618: -- Hi [~daryn], Thanks for the comment. I surely learne

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-10-25 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219694#comment-16219694 ] Daryn Sharp commented on HDFS-12618: I understand the problem, but as soon as you upda

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-10-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16219479#comment-16219479 ] Hadoop QA commented on HDFS-12618: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-10-23 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215919#comment-16215919 ] Xiao Chen commented on HDFS-12618: -- Thanks for the explanation [~wchevreuil]. The arrayli

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-10-23 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16214955#comment-16214955 ] Wellington Chevreuil commented on HDFS-12618: - Hi [~xiaochen], thanks for revi

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-10-20 Thread Xiao Chen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16213269#comment-16213269 ] Xiao Chen commented on HDFS-12618: -- Thanks for reporting and working on this [~wchevreuil

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-10-20 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16212858#comment-16212858 ] Hadoop QA commented on HDFS-12618: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-10-17 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16207768#comment-16207768 ] Hadoop QA commented on HDFS-12618: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-10-14 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204856#comment-16204856 ] Wellington Chevreuil commented on HDFS-12618: - Definitely environmental, tests

[jira] [Commented] (HDFS-12618) fsck -includeSnapshots reports wrong amount of total blocks

2017-10-14 Thread Wellington Chevreuil (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-12618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16204794#comment-16204794 ] Wellington Chevreuil commented on HDFS-12618: - I was going to add some tests t