[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16375169#comment-16375169
]
Wei Yan commented on HDFS-13043:
"short-cut" is too short. mistyped "i". Reassigned back
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347949#comment-16347949
]
Yiqun Lin commented on HDFS-13043:
--
Failed unit tests are not related. LGTM, +1.
[~elgoiri], as the work
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347752#comment-16347752
]
genericqa commented on HDFS-13043:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16347569#comment-16347569
]
genericqa commented on HDFS-13043:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346223#comment-16346223
]
genericqa commented on HDFS-13043:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16346188#comment-16346188
]
Yiqun Lin commented on HDFS-13043:
--
The patch almost looks good to me. Would you fix the related failure
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16345843#comment-16345843
]
genericqa commented on HDFS-13043:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344691#comment-16344691
]
Yiqun Lin commented on HDFS-13043:
--
Hi [~elgoiri], agree on your comments. There seems still some places
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344538#comment-16344538
]
genericqa commented on HDFS-13043:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344392#comment-16344392
]
genericqa commented on HDFS-13043:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16344142#comment-16344142
]
genericqa commented on HDFS-13043:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343848#comment-16343848
]
genericqa commented on HDFS-13043:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16343781#comment-16343781
]
Íñigo Goiri commented on HDFS-13043:
Thanks [~linyiqun] for the comments, I tackled most of them in
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340704#comment-16340704
]
Yiqun Lin commented on HDFS-13043:
--
Hi [~elgoiri], patch almost looks good to me.Seeing from the
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340486#comment-16340486
]
genericqa commented on HDFS-13043:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16340346#comment-16340346
]
Íñigo Goiri commented on HDFS-13043:
I think I fixed all the issues reported by Yetus in
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16339124#comment-16339124
]
Yiqun Lin commented on HDFS-13043:
--
Han't fully reviewed this. But would you mind attach the screenshot,
[
https://issues.apache.org/jira/browse/HDFS-13043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16338253#comment-16338253
]
genericqa commented on HDFS-13043:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
18 matches
Mail list logo