[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437129#comment-16437129 ] Hudson commented on HDFS-13418: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #1

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437094#comment-16437094 ] genericqa commented on HDFS-13418: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16437085#comment-16437085 ] Yiqun Lin commented on HDFS-13418: -- +1. Committing this. > NetworkTopology should be co

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434876#comment-16434876 ] Yiqun Lin commented on HDFS-13418: -- LGTM. [~Tao Jie], would you mind attaching the patch

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434237#comment-16434237 ] genericqa commented on HDFS-13418: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16434231#comment-16434231 ] Chen Liang commented on HDFS-13418: --- Thans [~Tao Jie] and [~linyiqun] for the followup!

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433887#comment-16433887 ] genericqa commented on HDFS-13418: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433776#comment-16433776 ] Yiqun Lin commented on HDFS-13418: -- Two comments for the latest patch: * Fix checkstyle

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433715#comment-16433715 ] genericqa commented on HDFS-13418: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433678#comment-16433678 ] Tao Jie commented on HDFS-13418: Thank you [~linyiqun] for your comments. For the UT, I th

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433619#comment-16433619 ] Yiqun Lin commented on HDFS-13418: -- Thanks [~Tao Jie] for updating the patch. Almost look

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433553#comment-16433553 ] Tao Jie commented on HDFS-13418: Updated the patch in which added default property in hdfs

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433457#comment-16433457 ] genericqa commented on HDFS-13418: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16433364#comment-16433364 ] Yiqun Lin commented on HDFS-13418: -- Hi [~Tao Jie], your proposal also makes sense to me.

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432565#comment-16432565 ] Chen Liang commented on HDFS-13418: --- Thanks for the discussion [~Tao Jie] and [~linyiqun

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432029#comment-16432029 ] Tao Jie commented on HDFS-13418: Thank you [~linyiqun] for your patient explanation. I att

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431918#comment-16431918 ] Yiqun Lin commented on HDFS-13418: -- Hi [~Tao Jie], {quote}1, Can we just remove net.topo

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431728#comment-16431728 ] Tao Jie commented on HDFS-13418: [~linyiqun] Thank you for your comment. I feel a little t

[jira] [Commented] (HDFS-13418) NetworkTopology should be configurable when enable DFSNetworkTopology

[ https://issues.apache.org/jira/browse/HDFS-13418?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431659#comment-16431659 ] Yiqun Lin commented on HDFS-13418: -- Hi [~Tao Jie], {{DFSNetworkTopology}} is specified fo