[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-24 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16662404#comment-16662404 ] Erik Krogen commented on HDFS-13924: Great, thanks [~csun]! > Handle BlockMissingException when

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-23 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661747#comment-16661747 ] Chao Sun commented on HDFS-13924: - Thanks [~xkrogen] for the help. The test change looks good to me. The

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661577#comment-16661577 ] Hadoop QA commented on HDFS-13924: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-23 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16661333#comment-16661333 ] Erik Krogen commented on HDFS-13924: v003 looks great, +1. Agreed that FindBugs is not related, and

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-22 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659827#comment-16659827 ] Chao Sun commented on HDFS-13924: - [~xkrogen]: could you take another look? The latest jenkins run looks

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16656100#comment-16656100 ] Hadoop QA commented on HDFS-13924: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-18 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655868#comment-16655868 ] Chao Sun commented on HDFS-13924: - Test failure seems unrelated. Attached patch v3 to fix the style

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655865#comment-16655865 ] Hadoop QA commented on HDFS-13924: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-18 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655641#comment-16655641 ] Chao Sun commented on HDFS-13924: - Thanks [~xkrogen] for the great comments! bq. In

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-18 Thread Erik Krogen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655480#comment-16655480 ] Erik Krogen commented on HDFS-13924: Hey [~csun], this is great stuff, thanks for doing this. I have

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16655007#comment-16655007 ] Hadoop QA commented on HDFS-13924: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-18 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654691#comment-16654691 ] Chao Sun commented on HDFS-13924: - Thanks [~vagarychen] for taking a look. The test failure is because we

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-17 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16654069#comment-16654069 ] Chen Liang commented on HDFS-13924: --- v0 patch looks to me overall, but the failed test 

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651175#comment-16651175 ] Hadoop QA commented on HDFS-13924: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16651167#comment-16651167 ] Hadoop QA commented on HDFS-13924: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-10-15 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16650996#comment-16650996 ] Chao Sun commented on HDFS-13924: - Thanks [~vagarychen]. Agree that it may be better to handle this on

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-09-20 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622626#comment-16622626 ] Chen Liang commented on HDFS-13924: --- Thanks for the update [~csun]! Just to add to my previous comment:

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-09-20 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16622487#comment-16622487 ] Chao Sun commented on HDFS-13924: - [~xkrogen] brought up a good point in

***UNCHECKED*** [jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-09-19 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16620240#comment-16620240 ] Chao Sun commented on HDFS-13924: - [~vagarychen] yes I think we can potentially fix on the server side as

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-09-17 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618281#comment-16618281 ] Chen Liang commented on HDFS-13924: --- Thanks [~csun]. I see, so I imagine the error did not happen on

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-09-17 Thread Chao Sun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618251#comment-16618251 ] Chao Sun commented on HDFS-13924: - [~vagarychen] yes the stack trace: {code:java} Caused by:

[jira] [Commented] (HDFS-13924) Handle BlockMissingException when reading from observer

2018-09-17 Thread Chen Liang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-13924?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16618247#comment-16618247 ] Chen Liang commented on HDFS-13924: --- Good finding, thanks for reporting [~csun]! I'm wondering, is