[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690185#comment-16690185
]
Chen Liang commented on HDFS-14017:
---
I've committed v014 patch to feature branch, thanks for all the
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690170#comment-16690170
]
Chen Liang commented on HDFS-14017:
---
Thanks for looking into this [~xkrogen]! I agree that there should
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689892#comment-16689892
]
Erik Krogen commented on HDFS-14017:
Even stranger now: This time around it claims that everything
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689855#comment-16689855
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689781#comment-16689781
]
Chen Liang commented on HDFS-14017:
---
Hmmm...thanks for the checking [~xkrogen]!
>
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689764#comment-16689764
]
Erik Krogen commented on HDFS-14017:
Hm.. Something is pretty wrong with Jenkins. It's not actually
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689747#comment-16689747
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688877#comment-16688877
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688867#comment-16688867
]
Konstantin Shvachko commented on HDFS-14017:
Looks good: +1 on v014
>
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688857#comment-16688857
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688837#comment-16688837
]
Chen Liang commented on HDFS-14017:
---
Thanks for the catch, removed those imports in v014 patch
>
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688831#comment-16688831
]
Erik Krogen commented on HDFS-14017:
You have a bunch of unused imports in ORPPWithIPFailover, but
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688814#comment-16688814
]
Chen Liang commented on HDFS-14017:
---
Thanks for the comments [~xkrogen]. Post v013 patch.
>
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16688316#comment-16688316
]
Erik Krogen commented on HDFS-14017:
Hey [~vagarychen], I think the new approach looks great! My
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687387#comment-16687387
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687354#comment-16687354
]
Chen Liang commented on HDFS-14017:
---
Post v012 patch to change how ORFPPWithIP is configured. Now the
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16687006#comment-16687006
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16686936#comment-16686936
]
Chen Liang commented on HDFS-14017:
---
v011 patch to fix checkstyle issues.
>
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685997#comment-16685997
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685962#comment-16685962
]
Konstantin Shvachko commented on HDFS-14017:
For the record, my assumptions in the comment
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685861#comment-16685861
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685811#comment-16685811
]
Chen Liang commented on HDFS-14017:
---
Thanks for the the detailed suggestions and post sharing
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685603#comment-16685603
]
Erik Krogen commented on HDFS-14017:
Hey [~vagarychen], v009 patch LGTM as long as we have a
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684658#comment-16684658
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684614#comment-16684614
]
Chen Liang commented on HDFS-14017:
---
Post v009 patch.
Had some offline discussion with [~shv] and
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682588#comment-16682588
]
Konstantin Shvachko commented on HDFS-14017:
I meant nameserviceID, rather than namespace.
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682168#comment-16682168
]
Chen Liang commented on HDFS-14017:
---
Thanks for sharing [~shv].
What did you mean by "the virtual
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16682145#comment-16682145
]
Konstantin Shvachko commented on HDFS-14017:
Had an offline discussion with Erik. The gist of
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680819#comment-16680819
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680779#comment-16680779
]
Chen Liang commented on HDFS-14017:
---
Updated Javadoc in v008 patch, thanks [~shv] for the offline
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680758#comment-16680758
]
Chen Liang commented on HDFS-14017:
---
The URI here is passed from
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680534#comment-16680534
]
Erik Krogen commented on HDFS-14017:
{quote}Probably should be based on different fs.defaultFS, which
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16680370#comment-16680370
]
Konstantin Shvachko commented on HDFS-14017:
The patch looks good. Really liked all changes
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679188#comment-16679188
]
Chen Liang commented on HDFS-14017:
---
Had some offline discussion with [~shv]. Turns out we can further
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679248#comment-16679248
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678668#comment-16678668
]
Chen Liang commented on HDFS-14017:
---
Hmm...I don't see it does not work, as long as both nn1 and nn2
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678626#comment-16678626
]
Erik Krogen commented on HDFS-14017:
{quote}
What did you by a non-default FS? I meant the config
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678601#comment-16678601
]
Chen Liang commented on HDFS-14017:
---
What did you by a non-default FS? I meant the config fs.defaultFS,
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16678570#comment-16678570
]
Erik Krogen commented on HDFS-14017:
Interesting... I see the issue now. I did not notice previously
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677550#comment-16677550
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677496#comment-16677496
]
Chen Liang commented on HDFS-14017:
---
Thanks for the review [~xkrogen]! Post v005 patch.
bq. Seems like
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677392#comment-16677392
]
Erik Krogen commented on HDFS-14017:
* Can we extend the Javadoc of
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677303#comment-16677303
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16677256#comment-16677256
]
Chen Liang commented on HDFS-14017:
---
Thanks for the review [~shv]! Post v004 patch
bq. 1. Main question
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16676068#comment-16676068
]
Konstantin Shvachko commented on HDFS-14017:
Checked v002 patch.
# Main question if we could
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675989#comment-16675989
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675932#comment-16675932
]
Chen Liang commented on HDFS-14017:
---
Post v003 patch based on the discussions above. Basically the only
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16675536#comment-16675536
]
Chen Liang commented on HDFS-14017:
---
[~xkrogen] yes, exactly, :) but yeah, the current patch can be
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673720#comment-16673720
]
Erik Krogen commented on HDFS-14017:
Okay, gotcha. I think I was confused by the mismatch of what
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673712#comment-16673712
]
Chen Liang commented on HDFS-14017:
---
Thanks for the clarification [~xkrogen].
bq. when the active
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673670#comment-16673670
]
Erik Krogen commented on HDFS-14017:
So the way I see it, ObserverReadProxyProvider has two
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673575#comment-16673575
]
Chen Liang commented on HDFS-14017:
---
Or, I guess I might not interpret the second correctly. Were you
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673561#comment-16673561
]
Chen Liang commented on HDFS-14017:
---
Thanks for the comment [~xkrogen]. Indeed a large part is like
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16673267#comment-16673267
]
Erik Krogen commented on HDFS-14017:
Hey [~vagarychen], as I understand it, this patch essentially
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672542#comment-16672542
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672388#comment-16672388
]
Chen Liang commented on HDFS-14017:
---
Post the wrong patch...will update with v002 patch
>
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672316#comment-16672316
]
Hadoop QA commented on HDFS-14017:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16672008#comment-16672008
]
Chen Liang commented on HDFS-14017:
---
Post v001 patch. The patch is to address two things:
1. To work
[
https://issues.apache.org/jira/browse/HDFS-14017?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663299#comment-16663299
]
Konstantin Shvachko commented on HDFS-14017:
This about honoring HA configuration. Updated
59 matches
Mail list logo
