[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16871573#comment-16871573
]
Hudson commented on HDFS-14085:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16813 (See
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16708285#comment-16708285
]
Akira Ajisaka commented on HDFS-14085:
--
Thanks [~ayushtkn] for the contribution and thanks
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16707661#comment-16707661
]
Íñigo Goiri commented on HDFS-14085:
+1 on [^HDFS-14085-HDFS-13891-09.patch].
> RBF: LS command for
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706669#comment-16706669
]
Surendra Singh Lilhore commented on HDFS-14085:
---
+1
> RBF: LS command for root shows wrong
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706132#comment-16706132
]
Hadoop QA commented on HDFS-14085:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706116#comment-16706116
]
Ayush Saxena commented on HDFS-14085:
-
Thanx [~surendrasingh] for the reviewing.
I have changed the
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16706114#comment-16706114
]
Surendra Singh Lilhore commented on HDFS-14085:
---
Thanks [~ayushtkn] for patch.
latest
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705839#comment-16705839
]
Hadoop QA commented on HDFS-14085:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705794#comment-16705794
]
Hadoop QA commented on HDFS-14085:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705780#comment-16705780
]
Ayush Saxena commented on HDFS-14085:
-
[~elgoiri] I have added a function in the Utility as
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705415#comment-16705415
]
Íñigo Goiri commented on HDFS-14085:
I would probably put one setter per line but yes, that'd be
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705177#comment-16705177
]
Ayush Saxena commented on HDFS-14085:
-
bq. static class HdfsMountPointFileStatus extends
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16705043#comment-16705043
]
Íñigo Goiri commented on HDFS-14085:
Yes, it is a little unfortunate and not sure if it's worth the
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16704704#comment-16704704
]
Ayush Saxena commented on HDFS-14085:
-
[~elgoiri] HdfsFileStatus is an immutable object I guess that
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16703491#comment-16703491
]
Íñigo Goiri commented on HDFS-14085:
I'm still a little bit torn with he new builder for the dir
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702696#comment-16702696
]
Ayush Saxena commented on HDFS-14085:
-
Thanx [~elgoiri] for reviewing. Have uploaded v6 with said
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702666#comment-16702666
]
Hadoop QA commented on HDFS-14085:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702300#comment-16702300
]
Íñigo Goiri commented on HDFS-14085:
A little unfortunate that for us to set the children number we
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16702094#comment-16702094
]
Hadoop QA commented on HDFS-14085:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701677#comment-16701677
]
Surendra Singh Lilhore commented on HDFS-14085:
---
Thanks [~ayushtkn] for the patch.
One
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701372#comment-16701372
]
Akira Ajisaka commented on HDFS-14085:
--
LGTM, +1. Thanks [~ayushtkn].
> RBF: LS command for root
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701365#comment-16701365
]
Hadoop QA commented on HDFS-14085:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701313#comment-16701313
]
Ayush Saxena commented on HDFS-14085:
-
Thanx [~ajisakaa] & [~elgoiri]
uploaded v4 with said changes.
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701304#comment-16701304
]
Akira Ajisaka commented on HDFS-14085:
--
Thanks [~ayushtkn] and [~elgoiri].
Minor nit: The first
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701114#comment-16701114
]
Íñigo Goiri commented on HDFS-14085:
[^HDFS-14085-HDFS-13891-03.patch] LGTM.
A minor nit; instead of:
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16701086#comment-16701086
]
Hadoop QA commented on HDFS-14085:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700962#comment-16700962
]
Ayush Saxena commented on HDFS-14085:
-
Uploaded v3 with the added test case checking resolution of
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700903#comment-16700903
]
Íñigo Goiri commented on HDFS-14085:
OK, let's also add a test that fails by itself.
> RBF: LS
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700866#comment-16700866
]
Ayush Saxena commented on HDFS-14085:
-
[~elgoiri]
Since we are using getListing() in the tests . All
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700856#comment-16700856
]
Íñigo Goiri commented on HDFS-14085:
I'm fine with one of the two:
* Do the After method cleaning all
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700846#comment-16700846
]
Ayush Saxena commented on HDFS-14085:
-
Thanks [~elgoiri] for the review!!!
{quote}I think we could
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700809#comment-16700809
]
Íñigo Goiri commented on HDFS-14085:
Thanks for splitting the tests; looks good.
We should fix those
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700580#comment-16700580
]
Hadoop QA commented on HDFS-14085:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16700476#comment-16700476
]
Ayush Saxena commented on HDFS-14085:
-
[~elgoiri] Uploaded v2 with said changes.
bq. What is the
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699569#comment-16699569
]
Íñigo Goiri commented on HDFS-14085:
Thanks [~ayushtkn] for [^HDFS-14085-HDFS-13891-01.patch].
*
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699429#comment-16699429
]
Hadoop QA commented on HDFS-14085:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699340#comment-16699340
]
Ayush Saxena commented on HDFS-14085:
-
Have uploaded v1 with the said change and covering test case
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696402#comment-16696402
]
Surendra Singh Lilhore commented on HDFS-14085:
---
Thanks [~ajisakaa].
{quote}If there are
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694972#comment-16694972
]
Íñigo Goiri commented on HDFS-14085:
Just to summarize, we should have unit tests covering:
* Normal
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694293#comment-16694293
]
Ayush Saxena commented on HDFS-14085:
-
[~elgoiri] [~ajisakaa] Thanks for the agreement!!!
By far as
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16694151#comment-16694151
]
Akira Ajisaka commented on HDFS-14085:
--
bq. User from directory owner group will get permission
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693626#comment-16693626
]
Íñigo Goiri commented on HDFS-14085:
OK, I'm not sure how to handler points in multiple subclusters
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692844#comment-16692844
]
Ayush Saxena commented on HDFS-14085:
-
{quote}What if the destination folder has "rwx--"
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692737#comment-16692737
]
Surendra Singh Lilhore commented on HDFS-14085:
---
{quote}Given that, I would propose to just
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692119#comment-16692119
]
Íñigo Goiri commented on HDFS-14085:
Internally, the mount point is not a folder and we have to map
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690800#comment-16690800
]
Ayush Saxena commented on HDFS-14085:
-
Thanx [~elgoiri] for the comment.
HDFS-13891 it made the
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689774#comment-16689774
]
Íñigo Goiri commented on HDFS-14085:
Thanks [~ayushtkn] for opening the JIRA; we should make it a
[
https://issues.apache.org/jira/browse/HDFS-14085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16689084#comment-16689084
]
Ayush Saxena commented on HDFS-14085:
-
*Probable solutions*
1. Make any extra entry in the state
48 matches
Mail list logo