[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244158#comment-17244158 ] Ayush Saxena commented on HDFS-14090: - Committed to trunk. Thanx [~fengnanli] and [~crh] for the

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17244144#comment-17244144 ] Íñigo Goiri commented on HDFS-14090: Thanks [~ayushtkn] for the reminder. Let's merge. My setup with

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17243788#comment-17243788 ] Ayush Saxena commented on HDFS-14090: - Looks this is concluded, [~elgoiri] do you want to hold it

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231627#comment-17231627 ] Íñigo Goiri commented on HDFS-14090: +1 on [^HDFS-14090.025.patch]. I'll give it a couple of days

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231451#comment-17231451 ] Yiqun Lin commented on HDFS-14090: -- Thanks for addressing the comments, [~fengnanli], LGTM, +1. > RBF:

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231108#comment-17231108 ] Hadoop QA commented on HDFS-14090: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17231064#comment-17231064 ] Fengnan Li commented on HDFS-14090: --- [^HDFS-14090.025.patch] to fix tests and address comments.

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230829#comment-17230829 ] Íñigo Goiri commented on HDFS-14090: I'm guessing we are doing the documentation part in HDFS-14558,

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230612#comment-17230612 ] Yiqun Lin commented on HDFS-14090: -- Hi [~fengnanli], two nits for the latest patch: {noformat} smaller

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230455#comment-17230455 ] Hadoop QA commented on HDFS-14090: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230394#comment-17230394 ] Fengnan Li commented on HDFS-14090: --- Uploaded [^HDFS-14090.024.patch] to add configs for it. I feel

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230347#comment-17230347 ] Yiqun Lin commented on HDFS-14090: -- Sounds good to me, let's address #2 comment, [~fengnanli]. > RBF:

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17230344#comment-17230344 ] Fengnan Li commented on HDFS-14090: --- Thanks for the review [~linyiqun] and here is the late response.

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17227189#comment-17227189 ] Yiqun Lin commented on HDFS-14090: -- Hi [~fengnanli], some minor comments from me: 1. I see here we

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17226806#comment-17226806 ] Íñigo Goiri commented on HDFS-14090: Thanks [~fengnanli] for [^HDFS-14090.023.patch]. The code looks

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225175#comment-17225175 ] Hadoop QA commented on HDFS-14090: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17225055#comment-17225055 ] Hadoop QA commented on HDFS-14090: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224976#comment-17224976 ] Íñigo Goiri commented on HDFS-14090: Thanks [~fengnanli] for fixing the javadocs in

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224472#comment-17224472 ] Hadoop QA commented on HDFS-14090: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224376#comment-17224376 ] Hadoop QA commented on HDFS-14090: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224360#comment-17224360 ] Fengnan Li commented on HDFS-14090: --- Thanks [~elgoiri] let's see whether [^HDFS-14090.020.patch] can

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224354#comment-17224354 ] Íñigo Goiri commented on HDFS-14090: I know it hasn't been there in the past but would you mind

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224327#comment-17224327 ] Hadoop QA commented on HDFS-14090: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17224314#comment-17224314 ] Fengnan Li commented on HDFS-14090: --- Uploaded [^HDFS-14090.019.patch] to fix styling issues.

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223973#comment-17223973 ] Hadoop QA commented on HDFS-14090: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223946#comment-17223946 ] Hadoop QA commented on HDFS-14090: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221812#comment-17221812 ] Hadoop QA commented on HDFS-14090: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221751#comment-17221751 ] Fengnan Li commented on HDFS-14090: --- Uploaded [^HDFS-14090.016.patch] to fix styling and unit tests >

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17221156#comment-17221156 ] Hui Fei commented on HDFS-14090: [~crh] Thanks for great work here, and [~fengnanli] thanks for taking

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218022#comment-17218022 ] Hadoop QA commented on HDFS-14090: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17218007#comment-17218007 ] Fengnan Li commented on HDFS-14090: --- Talked with [~crh] offline and I will take over the task. Great

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16944029#comment-16944029 ] Erik Krogen commented on HDFS-14090: Hey [~crh], strong apologies for my 1-2 days to get a review

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16942355#comment-16942355 ] Brahma Reddy Battula commented on HDFS-14090: - [~crh] thanks for great work here. I too liked

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940643#comment-16940643 ] Xiaoqiao He commented on HDFS-14090: Thanks [~crh] for your works and sorry for late response. 1.

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940620#comment-16940620 ] CR Hota commented on HDFS-14090: [~elgoiri] [~xkrogen] Thanks for your patience. Lets try and close this

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933624#comment-16933624 ] Íñigo Goiri commented on HDFS-14090: Thanks [~xkrogen], yes, please go ahead. Let's give it a couple

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933623#comment-16933623 ] Erik Krogen commented on HDFS-14090: I am +1 on overall implementation (have at least looked at every

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16933621#comment-16933621 ] Íñigo Goiri commented on HDFS-14090: I'd like to have a couple more official +1s. Anybody up?

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16932738#comment-16932738 ] CR Hota commented on HDFS-14090: Hey [~elgoiri] Should we commit this? Most of the folks had already

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928913#comment-16928913 ] CR Hota commented on HDFS-14090: [~elgoiri] Thanks for the final review. [~brahmareddy] [~aajisaka]

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928872#comment-16928872 ] Íñigo Goiri commented on HDFS-14090: +1 on [^HDFS-14090.014.patch]. > RBF: Improved isolation for

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928831#comment-16928831 ] Hadoop QA commented on HDFS-14090: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928774#comment-16928774 ] CR Hota commented on HDFS-14090: [~elgoiri] Thanks for the review. Uploaded v014. > RBF: Improved

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928754#comment-16928754 ] Íñigo Goiri commented on HDFS-14090: Thanks [~crh] for th update. In the future#get(), I feel that we

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928750#comment-16928750 ] CR Hota commented on HDFS-14090: [~elgoiri] Thanks a lot for the clarification. Have taken care of all

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16928364#comment-16928364 ] Hadoop QA commented on HDFS-14090: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16927089#comment-16927089 ] Íñigo Goiri commented on HDFS-14090: Right now, the test is doing a catch of the exception and then

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16926816#comment-16926816 ] CR Hota commented on HDFS-14090: [~elgoiri] Thanks for the review. Sorry, couldn't understand the second

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924587#comment-16924587 ] Íñigo Goiri commented on HDFS-14090: Thanks [~crh], it's cleaner with the IllegalArgumentException.

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924571#comment-16924571 ] Hadoop QA commented on HDFS-14090: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924468#comment-16924468 ] Íñigo Goiri commented on HDFS-14090: {quote} Both are theoretically misconfigurations and hence

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924427#comment-16924427 ] CR Hota commented on HDFS-14090: [~elgoiri] Thanks for the reviews. Some thoughts below. {quote}My main

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924413#comment-16924413 ] Íñigo Goiri commented on HDFS-14090: BTW, should we also add the fairness per user to the Router RPC

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919076#comment-16919076 ] Íñigo Goiri commented on HDFS-14090: My main issue is that PermitAllocationException is too generic.

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919031#comment-16919031 ] CR Hota commented on HDFS-14090: [~elgoiri] Thanks for the comments. Uploaded 011.patch Have taken care

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918892#comment-16918892 ] Hadoop QA commented on HDFS-14090: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16917061#comment-16917061 ] Íñigo Goiri commented on HDFS-14090: Minor comments: * Complete the javadocs for FairnessManager

[jira] [Commented] (HDFS-14090) RBF: Improved isolation for downstream name nodes. {Static}

[ https://issues.apache.org/jira/browse/HDFS-14090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916840#comment-16916840 ] CR Hota commented on HDFS-14090: Hey [~elgoiri] [~brahmareddy] [~aajisaka] [~xkrogen] , Could you help