[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797494#comment-16797494
]
Dinesh Chitlangia commented on HDFS-14176:
--
Thanks [~ajayydv] for commit and [~jojochuang] for
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16797479#comment-16797479
]
Hudson commented on HDFS-14176:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16251 (See
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785767#comment-16785767
]
Dinesh Chitlangia commented on HDFS-14176:
--
[~jojochuang] thanks for review and guidance. Let me
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777580#comment-16777580
]
Wei-Chiu Chuang commented on HDFS-14176:
+1
> Replace incorrect use of system property user.name
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777261#comment-16777261
]
Dinesh Chitlangia commented on HDFS-14176:
--
[~jojochuang] Patch 04 addresses review comments.
>
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776534#comment-16776534
]
Hadoop QA commented on HDFS-14176:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775746#comment-16775746
]
Wei-Chiu Chuang commented on HDFS-14176:
Looks almost good to me. Just one nit: could you also
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16770802#comment-16770802
]
Dinesh Chitlangia commented on HDFS-14176:
--
[~jojochuang] - Let me know if patch 03 looks good
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760430#comment-16760430
]
Hadoop QA commented on HDFS-14176:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760370#comment-16760370
]
Dinesh Chitlangia commented on HDFS-14176:
--
[~jojochuang] thank you for review/guidance. Patch
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760286#comment-16760286
]
Wei-Chiu Chuang commented on HDFS-14176:
It probably makes sense to catch the exception, log at
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760240#comment-16760240
]
Dinesh Chitlangia commented on HDFS-14176:
--
[~jojochuang] - Do you recommend that we catch and
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16760234#comment-16760234
]
Wei-Chiu Chuang commented on HDFS-14176:
Thanks for the patch. Sorry I was late for the review.
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745787#comment-16745787
]
Dinesh Chitlangia commented on HDFS-14176:
--
[~jojochuang] Request you to kindly review patch 02.
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733303#comment-16733303
]
Hadoop QA commented on HDFS-14176:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16733180#comment-16733180
]
Dinesh Chitlangia commented on HDFS-14176:
--
Attached patch 02 to address checkstyle issue.
>
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732712#comment-16732712
]
Hadoop QA commented on HDFS-14176:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732571#comment-16732571
]
Dinesh Chitlangia commented on HDFS-14176:
--
[~jojochuang] - Thanks, logged HADOOP-16026,
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16732321#comment-16732321
]
Wei-Chiu Chuang commented on HDFS-14176:
Thank you for the detailed analysis! That looks
[
https://issues.apache.org/jira/browse/HDFS-14176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16731211#comment-16731211
]
Dinesh Chitlangia commented on HDFS-14176:
--
[~jojochuang] - Thank you for reporting the issue
20 matches
Mail list logo
