[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16867909#comment-16867909 ] He Xiaoqiao commented on HDFS-14201: Thanks [~elgoiri] for your help and commit. It's OK that keep

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866839#comment-16866839 ] Hudson commented on HDFS-14201: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16778 (See

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866841#comment-16866841 ] Íñigo Goiri commented on HDFS-14201: Thanks [~surmountian] and [~hexiaoqiao] for the work here.

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866834#comment-16866834 ] Íñigo Goiri commented on HDFS-14201: Thanks [~hexiaoqiao] for addressing the comments. +1 on

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866547#comment-16866547 ] He Xiaoqiao commented on HDFS-14201: Run failed unit test local and both {{TestSafeMode}} and

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866283#comment-16866283 ] Hadoop QA commented on HDFS-14201: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866154#comment-16866154 ] He Xiaoqiao commented on HDFS-14201: Thanks [~elgoiri],[~surmountian]. [^HDFS-14201.009.patch] fi the

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866141#comment-16866141 ] Íñigo Goiri commented on HDFS-14201: Let's fix the checkstyle and whitespace in

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866040#comment-16866040 ] Xiao Liang commented on HDFS-14201: --- [^HDFS-14201.008.patch] LGTM too, thank [~hexiaoqiao] for the 

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866013#comment-16866013 ] Hadoop QA commented on HDFS-14201: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865984#comment-16865984 ] Íñigo Goiri commented on HDFS-14201: [^HDFS-14201.008.patch] LGTM. [~surmountian] any further

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865869#comment-16865869 ] He Xiaoqiao commented on HDFS-14201: Thanks [~elgoiri] for your comment. [^HDFS-14201.008.patch]

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865841#comment-16865841 ] Hadoop QA commented on HDFS-14201: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865755#comment-16865755 ] Íñigo Goiri commented on HDFS-14201: Thanks [~hexiaoqiao] for the update. A couple nits: * Can we use

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865624#comment-16865624 ] He Xiaoqiao commented on HDFS-14201: update patch [^HDFS-14201.007.patch] and fix checkstyle. check

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865108#comment-16865108 ] Hadoop QA commented on HDFS-14201: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865045#comment-16865045 ] He Xiaoqiao commented on HDFS-14201: Just rebase and re-upload [^HDFS-14201.006.patch], pending

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834636#comment-16834636 ] Hadoop QA commented on HDFS-14201: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16834468#comment-16834468 ] He Xiaoqiao commented on HDFS-14201: Hi [~surmountian] [~elgoiri], It is true that log output about

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781218#comment-16781218 ] Íñigo Goiri commented on HDFS-14201: I tried this internally, and ine small issue with

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780169#comment-16780169 ] He Xiaoqiao commented on HDFS-14201: +1 LGTM, Thanks [~surmountian]. > Ability to disallow safemode

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780154#comment-16780154 ] Xiao Liang commented on HDFS-14201: --- Thanks [~hexiaoqiao] for reviewing.

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779151#comment-16779151 ] Hadoop QA commented on HDFS-14201: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779063#comment-16779063 ] He Xiaoqiao commented on HDFS-14201: Thanks [~surmountian], [^HDFS-14201.004.patch] looks fine to

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779044#comment-16779044 ] Xiao Liang commented on HDFS-14201: --- Thanks [~hexiaoqiao], I uploaded [^HDFS-14201.004.patch] which

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777624#comment-16777624 ] He Xiaoqiao commented on HDFS-14201: Thanks [~surmountian] to push forward this issue. {quote} I

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16777427#comment-16777427 ] Xiao Liang commented on HDFS-14201: --- Thanks [~hexiaoqiao] for pointing out the manual transition, it's

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776531#comment-16776531 ] Hadoop QA commented on HDFS-14201: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776513#comment-16776513 ] He Xiaoqiao commented on HDFS-14201: Thanks [~surmountian] for quick response,

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776496#comment-16776496 ] Xiao Liang commented on HDFS-14201: --- Thanks [~elgoiri] for the information, I uploaded 

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776317#comment-16776317 ] Hadoop QA commented on HDFS-14201: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16776235#comment-16776235 ] He Xiaoqiao commented on HDFS-14201: [^HDFS-14201.002.patch] add new configuration element for

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16775564#comment-16775564 ] Íñigo Goiri commented on HDFS-14201: [~surmountian], let's fix the checstyle warnings. > Ability to

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774910#comment-16774910 ] Hadoop QA commented on HDFS-14201: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16774799#comment-16774799 ] He Xiaoqiao commented on HDFS-14201: Hi [~surmountian], [^HDFS-14201.001.patch] is my improvement for

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741953#comment-16741953 ] Steve Loughran commented on HDFS-14201: --- Yetus & github PRs is really close to shipping, will need

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741525#comment-16741525 ] He Xiaoqiao commented on HDFS-14201: [~surmountian] is it possible to check the namenode if in

[jira] [Commented] (HDFS-14201) Ability to disallow safemode NN to become active

[ https://issues.apache.org/jira/browse/HDFS-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16741435#comment-16741435 ] Íñigo Goiri commented on HDFS-14201: Now that we moved to gitbox I think there was a chance for