[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16789921#comment-16789921
]
Ekanth Sethuramalingam commented on HDFS-14317:
---
Thanks [~xkrogen].
> Standby does not
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788365#comment-16788365
]
Erik Krogen commented on HDFS-14317:
[~ekanth] I filed HDFS-14349 and assigned to you for now
>
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788363#comment-16788363
]
Ekanth Sethuramalingam commented on HDFS-14317:
---
Good point [~xkrogen]. I missed it too. I
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788289#comment-16788289
]
Erik Krogen commented on HDFS-14317:
I synced with [~ekanth] offline and he informed me that the
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786967#comment-16786967
]
Hudson commented on HDFS-14317:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #16156 (See
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786971#comment-16786971
]
Erik Krogen commented on HDFS-14317:
Thanks for the explanation, [~ekanth]. +1 from me. I just
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786412#comment-16786412
]
Ekanth Sethuramalingam commented on HDFS-14317:
---
With the
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785876#comment-16785876
]
Erik Krogen commented on HDFS-14317:
Hey [~ekanth], can you explain why the new test changes to
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785112#comment-16785112
]
star commented on HDFS-14317:
-
thanks [~ekanth].
> Standby does not trigger edit log rolling when
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785002#comment-16785002
]
Ekanth Sethuramalingam commented on HDFS-14317:
---
{quote}I am not very clear about 'With
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16784017#comment-16784017
]
star commented on HDFS-14317:
-
[~ekanth], nice patch.
I am not very clear about 'With in-progress edit log
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782223#comment-16782223
]
Hadoop QA commented on HDFS-14317:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782205#comment-16782205
]
Hadoop QA commented on HDFS-14317:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782170#comment-16782170
]
Chao Sun commented on HDFS-14317:
-
Regarding the time unit issue for log rolling and tailing, perhaps we
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782142#comment-16782142
]
Ekanth Sethuramalingam commented on HDFS-14317:
---
New patch [^HDFS-14317.004.patch] fixes
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782040#comment-16782040
]
Ekanth Sethuramalingam commented on HDFS-14317:
---
Thanks [~xkrogen] for the review. New
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781829#comment-16781829
]
Erik Krogen commented on HDFS-14317:
{quote}
the value is converted to seconds which will lose the
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781485#comment-16781485
]
Hadoop QA commented on HDFS-14317:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781318#comment-16781318
]
Ekanth Sethuramalingam commented on HDFS-14317:
---
{quote}That's not true, they both accept
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16781094#comment-16781094
]
Erik Krogen commented on HDFS-14317:
{quote}
Unfortunately, dfs.ha.tail-edits.period and
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780997#comment-16780997
]
Ekanth Sethuramalingam commented on HDFS-14317:
---
Thanks for the review Erik.
{quote} * The
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780895#comment-16780895
]
Hadoop QA commented on HDFS-14317:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16780780#comment-16780780
]
Erik Krogen commented on HDFS-14317:
The production code all LGTM. I have a few comments on the test:
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779842#comment-16779842
]
Ekanth Sethuramalingam commented on HDFS-14317:
---
Attached a patch [^HDFS-14317.001.patch]
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779663#comment-16779663
]
Erik Krogen commented on HDFS-14317:
Gotcha. Thank you for the detailed explanation -- you're a great
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16779655#comment-16779655
]
Ekanth Sethuramalingam commented on HDFS-14317:
---
{quote}
I wonder if the default value of
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778226#comment-16778226
]
Erik Krogen commented on HDFS-14317:
{quote}
I presume the reason why it also removes inprogress edit
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778201#comment-16778201
]
Ekanth Sethuramalingam commented on HDFS-14317:
---
Thanks [~xkrogen] for the comments.
[
https://issues.apache.org/jira/browse/HDFS-14317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16778130#comment-16778130
]
Erik Krogen commented on HDFS-14317:
Hey [~ekanth], thanks for reporting this. It seems that
29 matches
Mail list logo
