[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-03 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16809000#comment-16809000 ] Hudson commented on HDFS-14394: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #16337 (See

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-03 Thread Jim Brennan (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808843#comment-16808843 ] Jim Brennan commented on HDFS-14394: I am +1 on this (non-binding).  With gcc 4.8.5 on rhel7 my

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-03 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808700#comment-16808700 ] Wei-Chiu Chuang commented on HDFS-14394: FWIW, I have an environment that uses gcc 4.9.5 and the

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-02 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808184#comment-16808184 ] Sahil Takiar commented on HDFS-14394: - Thanks for the input Todd. One last thing I forgot to mention.

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-02 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808180#comment-16808180 ] Todd Lipcon commented on HDFS-14394: One more piece of related info here is that the concern about

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-02 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808173#comment-16808173 ] Todd Lipcon commented on HDFS-14394: BTW I should have said I'm +1 on this patch. I'll commit unless

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-02 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808172#comment-16808172 ] Todd Lipcon commented on HDFS-14394: I'm pretty certain that depending on GNU extensions to the C

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-02 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808138#comment-16808138 ] Eric Yang commented on HDFS-14394: -- [~stakiar] pedantic-errors flag forces syntax that is not defined by

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-02 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16808067#comment-16808067 ] Sahil Takiar commented on HDFS-14394: - I can add the {{-fextended-identifiers}} flag without any

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-02 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807986#comment-16807986 ] Eric Yang commented on HDFS-14394: -- [~stakiar] Thanks for the reminder about CMAKE_CXX_FLAGS, not

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-01 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807365#comment-16807365 ] Sahil Takiar commented on HDFS-14394: - [~eyang] do those tests pass locally on trunk without the

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-01 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807296#comment-16807296 ] Eric Yang commented on HDFS-14394: -- [~stakiar] It seems a little strange that it failed the first time,

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-01 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807272#comment-16807272 ] Sahil Takiar commented on HDFS-14394: - [~eyang] what was the compilation error that you hit? I double

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-01 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807253#comment-16807253 ] Hadoop QA commented on HDFS-14394: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-01 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807241#comment-16807241 ] Eric Yang commented on HDFS-14394: -- [~stakiar] If a small workaround can be applied without project

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-04-01 Thread Sahil Takiar (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807214#comment-16807214 ] Sahil Takiar commented on HDFS-14394: - Thanks for the input [~jojochuang], [~tlipcon]. Posted a patch

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-03-29 Thread Eric Yang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805292#comment-16805292 ] Eric Yang commented on HDFS-14394: -- What do people think about refactoring Hadoop-hdfs-native-client

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-03-28 Thread Todd Lipcon (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16804190#comment-16804190 ] Todd Lipcon commented on HDFS-14394: yea, looks like GCC5 turns on C99 mode by default. Tested gcc

[jira] [Commented] (HDFS-14394) Add -std=c99 / -std=gnu99 to libhdfs compile flags

2019-03-28 Thread Wei-Chiu Chuang (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-14394?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803938#comment-16803938 ] Wei-Chiu Chuang commented on HDFS-14394: We do mention gcc version supported in BUILD.txt