[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920340#comment-16920340
]
Chen Zhang commented on HDFS-14711:
---
Thanks [~ayushtkn] for the commit
> RBF: RBFMetrics throws
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920325#comment-16920325
]
Hudson commented on HDFS-14711:
---
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17218 (See
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920326#comment-16920326
]
Ayush Saxena commented on HDFS-14711:
-
Committed to trunk.
Thanx [~zhangchen] for the contribution!!!
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920309#comment-16920309
]
Ayush Saxena commented on HDFS-14711:
-
v005 LGTM +1
> RBF: RBFMetrics throws NullPointerException if
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920266#comment-16920266
]
Hadoop QA commented on HDFS-14711:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920262#comment-16920262
]
Chen Zhang commented on HDFS-14711:
---
Thanks [~ayushtkn] for your suggestion, I've go through all router
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920202#comment-16920202
]
Hadoop QA commented on HDFS-14711:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920177#comment-16920177
]
Ayush Saxena commented on HDFS-14711:
-
Thanx [~zhangchen] for confirming, Seems almost good.
Can we
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920176#comment-16920176
]
Chen Zhang commented on HDFS-14711:
---
Thanks [~ayushtkn] for the review.
{quote}Here you can directly
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16920065#comment-16920065
]
Ayush Saxena commented on HDFS-14711:
-
Thanx [~zhangchen] for the patch.
{code:java}
742
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16919664#comment-16919664
]
Chen Zhang commented on HDFS-14711:
---
Hi [~ayushtkn] and [~elgoiri], do you have time to help review
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915227#comment-16915227
]
Chen Zhang commented on HDFS-14711:
---
Hi [~ayushtkn], since HDFS-14656 is not updated for over one
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914388#comment-16914388
]
Hadoop QA commented on HDFS-14711:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914297#comment-16914297
]
Chen Zhang commented on HDFS-14711:
---
upload patch v3 to fix checkstyle error
> RBF: RBFMetrics throws
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914212#comment-16914212
]
Hadoop QA commented on HDFS-14711:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914119#comment-16914119
]
Chen Zhang commented on HDFS-14711:
---
Upload the patch v2, to handle null pointer properly in
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904681#comment-16904681
]
Chen Zhang commented on HDFS-14711:
---
Hi [~ayushtkn], agree with you, we need to add some NULL check. So
[
https://issues.apache.org/jira/browse/HDFS-14711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16904328#comment-16904328
]
Ayush Saxena commented on HDFS-14711:
-
That something we discussed at HDFS-14656, IMO we just need to
18 matches
Mail list logo
