[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912940#comment-16912940 ] Hudson commented on HDFS-14741: --- FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17166 (See

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912920#comment-16912920 ] Ayush Saxena commented on HDFS-14741: - Committed to trunk. Thanx [~xuzq_zander] for the contribution

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912897#comment-16912897 ] Ayush Saxena commented on HDFS-14741: - I even re triggered the build to confirm here, it passed in

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912890#comment-16912890 ] xuzq commented on HDFS-14741: - Thanks [~elgoiri] for the comment. TestStateStoreMembershipState run

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912762#comment-16912762 ] Hadoop QA commented on HDFS-14741: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16912501#comment-16912501 ] Íñigo Goiri commented on HDFS-14741: TestStateStoreMembershipState is a little suspicious as I

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911909#comment-16911909 ] Hadoop QA commented on HDFS-14741: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911862#comment-16911862 ] xuzq commented on HDFS-14741: - Thanks [~elgoiri], please review [^HDFS-14741-trunk-007.patch] > RBF:

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911715#comment-16911715 ] Hadoop QA commented on HDFS-14741: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911512#comment-16911512 ] Íñigo Goiri commented on HDFS-14741: The test looks good now. Can we update the comments there? For

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911367#comment-16911367 ] xuzq commented on HDFS-14741: - Thanks [~ayushtkn], update [^HDFS-14741-trunk-006.patch] fix check style and

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911360#comment-16911360 ] Ayush Saxena commented on HDFS-14741: - Apart from the checkstyle, LGTM. > RBF: RecoverLease should

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911264#comment-16911264 ] Hadoop QA commented on HDFS-14741: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911201#comment-16911201 ] xuzq commented on HDFS-14741: - Thanks [~ayushtkn] for the comment, it is very helpful to me.  Please review 

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911187#comment-16911187 ] Ayush Saxena commented on HDFS-14741: - Thanx [~xuzq_zander] for the patch There is no functional

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911045#comment-16911045 ] Hadoop QA commented on HDFS-14741: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911013#comment-16911013 ] xuzq commented on HDFS-14741: - Thanks [~ayushtkn] for the comment. Please review 

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910977#comment-16910977 ] Ayush Saxena commented on HDFS-14741: - The test seems to be flaky: {code:java}

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910959#comment-16910959 ] Hadoop QA commented on HDFS-14741: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910921#comment-16910921 ] xuzq commented on HDFS-14741: - [~elgoiri]  Thanks very much for your comment, it is very helpful to me.

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910812#comment-16910812 ] Íñigo Goiri commented on HDFS-14741: Not a big fan of changing the visibility of DFSClient, isn't

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16910161#comment-16910161 ] Ayush Saxena commented on HDFS-14741: - Thanx [~xuzq_zander] for the patch, fix LGTM. I guess for the

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909699#comment-16909699 ] xuzq commented on HDFS-14741: - Thanks [~elgoiri] for the comment. Add new mount point in testSetup(), so

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909335#comment-16909335 ] Íñigo Goiri commented on HDFS-14741: [^HDFS-14741-trunk-001.patch] LGTM. Just one question: why the

[jira] [Commented] (HDFS-14741) RBF: RecoverLease should be return false when the file is open in multiple destination

[ https://issues.apache.org/jira/browse/HDFS-14741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16909054#comment-16909054 ] Hadoop QA commented on HDFS-14741: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||