[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094178#comment-17094178
]
bianqi commented on HDFS-14758:
---
[~kihwal] Due to code adjustments, resulting in comment errors, please
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034937#comment-17034937
]
Kihwal Lee commented on HDFS-14758:
---
Cherry-picked to branch-2.9 and branch-2.8 as well.
> Decrease
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034789#comment-17034789
]
Hudson commented on HDFS-14758:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17942 (See
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034707#comment-17034707
]
Kihwal Lee commented on HDFS-14758:
---
+1 The patch looks good. The white space warning is from the XML
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034603#comment-17034603
]
Hadoop QA commented on HDFS-14758:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17034446#comment-17034446
]
hemanthboyina commented on HDFS-14758:
--
failure test case was not related
attached patch for white
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033831#comment-17033831
]
Hadoop QA commented on HDFS-14758:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033779#comment-17033779
]
Hadoop QA commented on HDFS-14758:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17033684#comment-17033684
]
Kihwal Lee commented on HDFS-14758:
---
Re-attached the patch to kick the build again.
> Decrease lease
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17032321#comment-17032321
]
Hadoop QA commented on HDFS-14758:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031851#comment-17031851
]
hemanthboyina commented on HDFS-14758:
--
thanks for the review [~kihwal]
I have updated the patch ,
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026066#comment-17026066
]
Kihwal Lee commented on HDFS-14758:
---
It looks like also {{FSNamesystem}} needs to convert the unit.
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17026060#comment-17026060
]
Kihwal Lee commented on HDFS-14758:
---
The hard limit is internally in milliseconds. However, the config
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993191#comment-16993191
]
hemanthboyina commented on HDFS-14758:
--
test failures and findbug is not realted . Please review the
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992981#comment-16992981
]
Hadoop QA commented on HDFS-14758:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992846#comment-16992846
]
hemanthboyina commented on HDFS-14758:
--
updated the patch with checkstyle issue fixed , please
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990493#comment-16990493
]
Hadoop QA commented on HDFS-14758:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16990435#comment-16990435
]
hemanthboyina commented on HDFS-14758:
--
have updated the property in hdfs-default.xml
please review
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16950147#comment-16950147
]
Hadoop QA commented on HDFS-14758:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924226#comment-16924226
]
hemanthboyina commented on HDFS-14758:
--
attached patch , pls review [~kihwal] [~jojochuang]
>
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922935#comment-16922935
]
Hadoop QA commented on HDFS-14758:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922757#comment-16922757
]
Kihwal Lee commented on HDFS-14758:
---
Make it as a namenode config with a default of 20 minutes.
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16922584#comment-16922584
]
hemanthboyina commented on HDFS-14758:
--
renew lease in client is using Lease Hard Limit
{code:java}
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921793#comment-16921793
]
Wei-Chiu Chuang commented on HDFS-14758:
I think Kihwal is much more experienced than I do so
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16921580#comment-16921580
]
hemanthboyina commented on HDFS-14758:
--
should change the hard coded value or should make it
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918839#comment-16918839
]
Kihwal Lee commented on HDFS-14758:
---
Unconditionally calling recoverLease() on a failure will work when
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16918829#comment-16918829
]
hemanthboyina commented on HDFS-14758:
--
[~jojochuang] [~eepayne] should we go ahead by changing the
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915244#comment-16915244
]
hemanthboyina commented on HDFS-14758:
--
yes [~zhangchen] even decreasing hard limit doesn't solve in
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914770#comment-16914770
]
Chen Zhang commented on HDFS-14758:
---
Hi [~jojochuang] and [~hemanthboyina], HDFS-14694 actually want to
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914697#comment-16914697
]
Wei-Chiu Chuang commented on HDFS-14758:
This and HDFS-14694 are trying to solve the same problem
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16914576#comment-16914576
]
hemanthboyina commented on HDFS-14758:
--
hi [~jojochuang] whats your take on this
feel +HDFS-14694+
[
https://issues.apache.org/jira/browse/HDFS-14758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16911771#comment-16911771
]
Wei-Chiu Chuang commented on HDFS-14758:
Somewhat similar, how to you think about HDFS-14694?
32 matches
Mail list logo