[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967713#comment-16967713 ] Hudson commented on HDFS-14775: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17609 (See

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967691#comment-16967691 ] Íñigo Goiri commented on HDFS-14775: Thanks [~zhangchen] for the patch and [~xkrogen] and

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967617#comment-16967617 ] Erik Krogen commented on HDFS-14775: +1 thanks [~zhangchen]! > Add Timestamp for longest FSN

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967196#comment-16967196 ] Xiaoqiao He commented on HDFS-14775: [^HDFS-14775.005.patch] LGTM, +1. Thanks [~zhangchen]. > Add

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967185#comment-16967185 ] Íñigo Goiri commented on HDFS-14775: +1 on [^HDFS-14775.005.patch]. [~xkrogen], please take a final

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16967181#comment-16967181 ] Chen Zhang commented on HDFS-14775: --- Hi [~xkrogen] [~elgoiri] [~hexiaoqiao], any further comments? >

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959549#comment-16959549 ] Hadoop QA commented on HDFS-14775: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959450#comment-16959450 ] Chen Zhang commented on HDFS-14775: --- Thanks [~xkrogen] for your comments, update patch v5. > Add

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959206#comment-16959206 ] Erik Krogen commented on HDFS-14775: I only took a quick look but it seems like a good change. 2

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959106#comment-16959106 ] Íñigo Goiri commented on HDFS-14775: [~xkrogen], [~shv], thoughts? > Add Timestamp for longest FSN

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958857#comment-16958857 ] Hadoop QA commented on HDFS-14775: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958833#comment-16958833 ] Hadoop QA commented on HDFS-14775: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958657#comment-16958657 ] Chen Zhang commented on HDFS-14775: --- Uploaded patch v4, removed the override of \{{hashCode()}} and

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958641#comment-16958641 ] Chen Zhang commented on HDFS-14775: --- I agree that \{{HashCodeBuilder}} and \{{EqualsBuilder}} is a

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958525#comment-16958525 ] Íñigo Goiri commented on HDFS-14775: For the hashCode and the equals, if we are implementing it to

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958486#comment-16958486 ] Chen Zhang commented on HDFS-14775: --- Hi [~hexiaoqiao] and [~elgoiri] ,Thanks for your comments, sorry

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16941132#comment-16941132 ] Íñigo Goiri commented on HDFS-14775: For the hashCode and the equals, I usually prefer using

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16940674#comment-16940674 ] Xiaoqiao He commented on HDFS-14775: Thanks [~zhangchen] for your works. This improvement is useful

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16938662#comment-16938662 ] Chen Zhang commented on HDFS-14775: --- Hi [~xkrogen], you've worked on the related code, do you have time

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924939#comment-16924939 ] Hadoop QA commented on HDFS-14775: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924885#comment-16924885 ] Chen Zhang commented on HDFS-14775: --- Just realized that {{longestWriteLockHeldInfo}} don't need to be

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16924848#comment-16924848 ] Chen Zhang commented on HDFS-14775: --- Hi [~xkrogen] and [~linyiqun], do you have time to help review

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16916081#comment-16916081 ] Hadoop QA commented on HDFS-14775: -- | (/) *{color:green}+1 overall{color}* | \\ \\ || Vote || Subsystem

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915906#comment-16915906 ] Chen Zhang commented on HDFS-14775: --- Upload patch v2 to fix checkstyle error, and all the failed test

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915814#comment-16915814 ] Hadoop QA commented on HDFS-14775: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14775) Add Timestamp for longest FSN write/read lock held log

[ https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16915284#comment-16915284 ] Chen Zhang commented on HDFS-14775: --- cc [~xkrogen] and [~linyiqun]. > Add Timestamp for longest FSN