[jira] [Commented] (HDFS-14935) Refactor DFSNetworkTopology#isNodeInScope

2019-10-29 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961750#comment-16961750 ] Hudson commented on HDFS-14935: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17580 (See

[jira] [Commented] (HDFS-14935) Refactor DFSNetworkTopology#isNodeInScope

2019-10-29 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961736#comment-16961736 ] Ayush Saxena commented on HDFS-14935: - Committed to trunk. Thanx [~leosun08] for the contribution!!!

[jira] [Commented] (HDFS-14935) Refactor DFSNetworkTopology#isNodeInScope

2019-10-29 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961731#comment-16961731 ] Ayush Saxena commented on HDFS-14935: - +1 > Refactor DFSNetworkTopology#isNodeInScope >

[jira] [Commented] (HDFS-14935) Refactor DFSNetworkTopology#isNodeInScope

2019-10-28 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961610#comment-16961610 ] Lisheng Sun commented on HDFS-14935: yeah, i think it is necessary to replace "/" with the constant

[jira] [Commented] (HDFS-14935) Refactor DFSNetworkTopology#isNodeInScope

2019-10-28 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961293#comment-16961293 ] Ayush Saxena commented on HDFS-14935: - Is this just replacing {{"/"}} with

[jira] [Commented] (HDFS-14935) Refactor DFSNetworkTopology#isNodeInScope

2019-10-28 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16961178#comment-16961178 ] Lisheng Sun commented on HDFS-14935: [~ayushtkn] Could you have time to take a reivew for the 003

[jira] [Commented] (HDFS-14935) Refactor DFSNetworkTopology#isNodeInScope

2019-10-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960420#comment-16960420 ] Hadoop QA commented on HDFS-14935: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14935) Refactor DFSNetworkTopology#isNodeInScope

2019-10-26 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960395#comment-16960395 ] Lisheng Sun commented on HDFS-14935: i agree your idea. before code getNode() has already checked 

[jira] [Commented] (HDFS-14935) Refactor DFSNetworkTopology#isNodeInScope

2019-10-26 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960321#comment-16960321 ] Ayush Saxena commented on HDFS-14935: - Yes, it should stop, means if it is moving ahead, it is sure

[jira] [Commented] (HDFS-14935) Refactor DFSNetworkTopology#isNodeInScope

2019-10-26 Thread Lisheng Sun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16960293#comment-16960293 ] Lisheng Sun commented on HDFS-14935: [~ayushtkn] i think if there is illegalArgumentException, it

[jira] [Commented] (HDFS-14935) Refactor DFSNetworkTopology#isNodeInScope

2019-10-25 Thread Ayush Saxena (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16959894#comment-16959894 ] Ayush Saxena commented on HDFS-14935: - Here the checks which throw illegalArgumentException will be