[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-12-04 Thread Yuval Degani (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16988086#comment-16988086 ] Yuval Degani commented on HDFS-15010: - Thank you, [~surendrasingh]! >

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-12-03 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987532#comment-16987532 ] Surendra Singh Lilhore commented on HDFS-15010: --- [~yuvaldeg],  Sure, I will do it. Need to

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-12-03 Thread Yuval Degani (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987305#comment-16987305 ] Yuval Degani commented on HDFS-15010: - [~surendrasingh], would you consider backporting this patch to

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-28 Thread Hudson (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16984600#comment-16984600 ] Hudson commented on HDFS-15010: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #17709 (See

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-27 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983980#comment-16983980 ] Íñigo Goiri commented on HDFS-15010: Not the fastest test but all this package is fairly expensive.

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-27 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983971#comment-16983971 ] Hadoop QA commented on HDFS-15010: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-27 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983790#comment-16983790 ] Surendra Singh Lilhore commented on HDFS-15010: --- Fixed checkstyle.. >

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-27 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983417#comment-16983417 ] Hadoop QA commented on HDFS-15010: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-26 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983209#comment-16983209 ] Surendra Singh Lilhore commented on HDFS-15010: --- Attached v4 patch. >

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-26 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983201#comment-16983201 ] Surendra Singh Lilhore commented on HDFS-15010: --- {quote}{{TestFsVolumeList}} looks

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-26 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983181#comment-16983181 ] Íñigo Goiri commented on HDFS-15010: {{TestFsVolumeList}} looks suspicious. >

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982945#comment-16982945 ] Hadoop QA commented on HDFS-15010: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-26 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982915#comment-16982915 ] Íñigo Goiri commented on HDFS-15010: BTW, I checked the test and is a little long (~5 seconds). Is

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982896#comment-16982896 ] Hadoop QA commented on HDFS-15010: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-26 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982789#comment-16982789 ] Surendra Singh Lilhore commented on HDFS-15010: --- Thanks [~elgoiri] , attached v3 patch. >

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-26 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982745#comment-16982745 ] Íñigo Goiri commented on HDFS-15010: Probably we should make the assertTrue an assertEquals. Other

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-26 Thread Surendra Singh Lilhore (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982744#comment-16982744 ] Surendra Singh Lilhore commented on HDFS-15010: --- Thanks [~elgoiri]  for review. Just added

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-25 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16981918#comment-16981918 ] Íñigo Goiri commented on HDFS-15010: Is there an easy test we can add to verify that two parallel

[jira] [Commented] (HDFS-15010) BlockPoolSlice#addReplicaThreadPool static pool should be initialized by static method

2019-11-23 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-15010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980897#comment-16980897 ] Hadoop QA commented on HDFS-15010: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||