[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17416724#comment-17416724
]
Xiaoqiao He commented on HDFS-15075:
Cherry-pick to branch-3.2
> Remove process command timing from
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066986#comment-17066986
]
Hudson commented on HDFS-15075:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18090 (See
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066960#comment-17066960
]
Íñigo Goiri commented on HDFS-15075:
Thanks [~hexiaoqiao] for the fix and [~weichiu] for the review.
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066856#comment-17066856
]
Wei-Chiu Chuang commented on HDFS-15075:
+1
> Remove process command timing from BPServiceActor
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066838#comment-17066838
]
Íñigo Goiri commented on HDFS-15075:
Thanks for doing the split.
[^HDFS-15075.009.patch] LGTM and it
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066733#comment-17066733
]
Hadoop QA commented on HDFS-15075:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1703#comment-1703
]
Xiaoqiao He commented on HDFS-15075:
Hi [~weichiu],[~elgoiri], add metrics for {{FsDatasetImpl}}
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066637#comment-17066637
]
Xiaoqiao He commented on HDFS-15075:
update to v009, and fix findbugs.
> Remove process command
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066590#comment-17066590
]
Hadoop QA commented on HDFS-15075:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066456#comment-17066456
]
Xiaoqiao He commented on HDFS-15075:
Thanks [~weichiu],[~elgoiri] for your suggestions, v008 try to
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066208#comment-17066208
]
Íñigo Goiri commented on HDFS-15075:
Thanks [~weichiu] for the comment, I think it is fair.
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065343#comment-17065343
]
Wei-Chiu Chuang commented on HDFS-15075:
Great work. I wish the extra metrics are a separate
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065158#comment-17065158
]
Íñigo Goiri commented on HDFS-15075:
+1 on [^HDFS-15075.007.patch].
Let's see what Jenkins says
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065055#comment-17065055
]
Wei-Chiu Chuang commented on HDFS-15075:
Retriggered jenkins:
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064541#comment-17064541
]
Xiaoqiao He commented on HDFS-15075:
Thanks [~elgoiri] for your good catches, v007 try to update the
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064329#comment-17064329
]
Íñigo Goiri commented on HDFS-15075:
Thanks [~hexiaoqiao] for the updated patch.
Good call on the doc
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064243#comment-17064243
]
Xiaoqiao He commented on HDFS-15075:
Thanks [~elgoiri] for your comments, v006 try to update
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063944#comment-17063944
]
Íñigo Goiri commented on HDFS-15075:
Yetus is misbehaving these days
Anyway, a couple minor
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063838#comment-17063838
]
Xiaoqiao He commented on HDFS-15075:
Considering HDFS-15113 has pushed to trunk, should we continue
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013510#comment-17013510
]
Hadoop QA commented on HDFS-15075:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17013457#comment-17013457
]
Xiaoqiao He commented on HDFS-15075:
Thanks [~elgoiri] and [~dabecker] for your review comments, v004
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17011012#comment-17011012
]
Íñigo Goiri commented on HDFS-15075:
[~dabecker] helped with an internal review and also noticed a
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010864#comment-17010864
]
Íñigo Goiri commented on HDFS-15075:
* Can we make DFS_DATANODE_PROCESS_COMMANDS_THRESHOLD_KEY be a
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004725#comment-17004725
]
Hadoop QA commented on HDFS-15075:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004667#comment-17004667
]
Xiaoqiao He commented on HDFS-15075:
update v003, fix failed unit tests and checkstyle.
> Remove
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004063#comment-17004063
]
Hadoop QA commented on HDFS-15075:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17004062#comment-17004062
]
Hadoop QA commented on HDFS-15075:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003453#comment-17003453
]
Xiaoqiao He commented on HDFS-15075:
Jenkins not trigger here, any issues?
> Remove process command
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17003317#comment-17003317
]
Xiaoqiao He commented on HDFS-15075:
Thanks [~elgoiri] for your reviews.
v002 try to fix comments
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17001045#comment-17001045
]
Íñigo Goiri commented on HDFS-15075:
I would take this opportunity to improve this in two ways:
*
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000844#comment-17000844
]
Hadoop QA commented on HDFS-15075:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000727#comment-17000727
]
Xiaoqiao He commented on HDFS-15075:
v001 keep the original semantic and move tracing time to
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000581#comment-17000581
]
Xiaoqiao He commented on HDFS-15075:
Thanks [~elgoiri] for your report, I would like to work on that.
[
https://issues.apache.org/jira/browse/HDFS-15075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000288#comment-17000288
]
Íñigo Goiri commented on HDFS-15075:
[~hexiaoqiao], thought here?
I am referring to:
{code}
34 matches
Mail list logo
