[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058882#comment-17058882
]
Hudson commented on HDFS-15155:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18050 (See
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058861#comment-17058861
]
Ayush Saxena commented on HDFS-15155:
-
Committed to trunk.
Thanx [~huanghaibin] for the contribution
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058857#comment-17058857
]
Ayush Saxena commented on HDFS-15155:
-
v005 LGTM +1
> writeIoRate of DataNodeVolumeMetrics is never
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058450#comment-17058450
]
Hadoop QA commented on HDFS-15155:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058374#comment-17058374
]
Haibin Huang commented on HDFS-15155:
-
[~ayushtkn], you are right, it can directly use
{code:java}
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058363#comment-17058363
]
Ayush Saxena commented on HDFS-15155:
-
Thanx [~huanghaibin] for the patch. Minor doubt :
{code:java}
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17058357#comment-17058357
]
Haibin Huang commented on HDFS-15155:
-
[~elgoiri], can this patch commit to trunk?
> writeIoRate of
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051487#comment-17051487
]
Íñigo Goiri commented on HDFS-15155:
The failed unit tests are unrelated.
+1 on
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051385#comment-17051385
]
Hadoop QA commented on HDFS-15155:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050487#comment-17050487
]
Íñigo Goiri commented on HDFS-15155:
* Let's fix the checkstyle.
* Instead of assertTrue ==, use
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050347#comment-17050347
]
Hadoop QA commented on HDFS-15155:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050193#comment-17050193
]
Haibin Huang commented on HDFS-15155:
-
[~elgoiri] I have updated the patch. Please review it.
>
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047182#comment-17047182
]
Haibin Huang commented on HDFS-15155:
-
Ok, i will update the patch soon
> writeIoRate of
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047179#comment-17047179
]
Íñigo Goiri commented on HDFS-15155:
I do think we need some assert, right now we are not really
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047171#comment-17047171
]
Haibin Huang commented on HDFS-15155:
-
I think TestDataNodeVolumeMetrics#testVolumeMetrics has
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046949#comment-17046949
]
Hadoop QA commented on HDFS-15155:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046836#comment-17046836
]
Íñigo Goiri commented on HDFS-15155:
The test is not checking anything, can we add there some
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17046809#comment-17046809
]
Haibin Huang commented on HDFS-15155:
-
[~elgoiri] [~ayushtkn] , i have updated the patch, can you
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031945#comment-17031945
]
Íñigo Goiri commented on HDFS-15155:
Can you add a test?
> writeIoRate of DataNodeVolumeMetrics is
[
https://issues.apache.org/jira/browse/HDFS-15155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17031691#comment-17031691
]
Hadoop QA commented on HDFS-15155:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
20 matches
Mail list logo
