[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073668#comment-17073668
]
Akira Ajisaka commented on HDFS-15169:
--
Filed HDFS-15258
> RBF: Router FSCK should consider the
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073658#comment-17073658
]
Akira Ajisaka commented on HDFS-15169:
--
Thank you for your reply. I'll file a JIRA and create a PR
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073562#comment-17073562
]
Ayush Saxena commented on HDFS-15169:
-
Thanx for confirming.
Then it would be good if we can add a
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073450#comment-17073450
]
Akira Ajisaka commented on HDFS-15169:
--
bq. Ideally we should have marked RouterFSCK as EVOLVING or
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17073378#comment-17073378
]
Ayush Saxena commented on HDFS-15169:
-
bq. Do we need to replace it at Router when receive result
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17072403#comment-17072403
]
Xiaoqiao He commented on HDFS-15169:
Thanks [~ayushtkn] for your helpful review comments.
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070372#comment-17070372
]
Ayush Saxena commented on HDFS-15169:
-
Thanx [~hexiaoqiao] for confirming, I tried tweaking the test
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070365#comment-17070365
]
Hadoop QA commented on HDFS-15169:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070339#comment-17070339
]
Xiaoqiao He commented on HDFS-15169:
v005 try to fix findbugs and checkstyle. And update all mount
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070321#comment-17070321
]
Hadoop QA commented on HDFS-15169:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070291#comment-17070291
]
Xiaoqiao He commented on HDFS-15169:
Thanks [~ayushtkn], Great catch. It is exactly a bug that we do
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069348#comment-17069348
]
Ayush Saxena commented on HDFS-15169:
-
Thanx [~hexiaoqiao] for the patch.
Seems fine, but in the
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17069134#comment-17069134
]
Íñigo Goiri commented on HDFS-15169:
+1 on [^HDFS-15169.003.patch].
> RBF: Router FSCK should
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068910#comment-17068910
]
Hadoop QA commented on HDFS-15169:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17068823#comment-17068823
]
Xiaoqiao He commented on HDFS-15169:
Thanks [~elgoiri] for your reviews.
v003 try to refactor the
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17067989#comment-17067989
]
Íñigo Goiri commented on HDFS-15169:
Thanks [~hexiaoqiao] for the unit test, it covers my concerns.
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066680#comment-17066680
]
Hadoop QA commented on HDFS-15169:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066635#comment-17066635
]
Xiaoqiao He commented on HDFS-15169:
Thanks [~elgoiri] for your reviews. v002 add unit test for fsck
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17065162#comment-17065162
]
Íñigo Goiri commented on HDFS-15169:
Thanks [~hexiaoqiao].
Is it possible to add a test that is a
[
https://issues.apache.org/jira/browse/HDFS-15169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064569#comment-17064569
]
Xiaoqiao He commented on HDFS-15169:
Attach Jenkins result link
20 matches
Mail list logo