[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071223#comment-17071223
]
Hudson commented on HDFS-15196:
---
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #18104 (See
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071218#comment-17071218
]
Íñigo Goiri commented on HDFS-15196:
Thanks [~fengnanli] for the patch and [~ayushtkn] for the
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071112#comment-17071112
]
Ayush Saxena commented on HDFS-15196:
-
v014 LGTM +1
> RBF: RouterRpcServer getListing cannot list
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071098#comment-17071098
]
Hadoop QA commented on HDFS-15196:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17071051#comment-17071051
]
Fengnan Li commented on HDFS-15196:
---
Thanks [~ayushtkn] [~elgoiri] Upload [^HDFS-15196.014.patch] to
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070948#comment-17070948
]
Ayush Saxena commented on HDFS-15196:
-
Thanx [~fengnanli] v13 Looks good.
just can you check :
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070609#comment-17070609
]
Íñigo Goiri commented on HDFS-15196:
+1 on [^HDFS-15196.013.patch].
[~ayushtkn], do you mind taking
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070505#comment-17070505
]
Hadoop QA commented on HDFS-15196:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070458#comment-17070458
]
Fengnan Li commented on HDFS-15196:
---
Thanks [~elgoiri] for the detailed explanation. I have made
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070392#comment-17070392
]
Íñigo Goiri commented on HDFS-15196:
I was referring to:
{code}
// Append router mount point only
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070202#comment-17070202
]
Hadoop QA commented on HDFS-15196:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070193#comment-17070193
]
Fengnan Li commented on HDFS-15196:
---
Thanks [~elgoiri]
I fixed point one, but it is hard to simplify
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070162#comment-17070162
]
Íñigo Goiri commented on HDFS-15196:
The failed tests are related.
Minor comments:
* If we are going
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070160#comment-17070160
]
Hadoop QA commented on HDFS-15196:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17070149#comment-17070149
]
Fengnan Li commented on HDFS-15196:
---
[~ayushtkn] [~elgoiri] I added some logic to include the remaining
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17066315#comment-17066315
]
Íñigo Goiri commented on HDFS-15196:
If possible, I would like to have the correct remaining entries
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064175#comment-17064175
]
Ayush Saxena commented on HDFS-15196:
-
Yes, at the end, the listing will be complete only. But the
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064094#comment-17064094
]
Fengnan Li commented on HDFS-15196:
---
[~ayushtkn] Thanks for the explanation. I agree that from a
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064011#comment-17064011
]
Ayush Saxena commented on HDFS-15196:
-
For the end user, the remaining entries aren't distinguished
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063636#comment-17063636
]
Fengnan Li commented on HDFS-15196:
---
Thanks for the review [~ayushtkn] [~elgoiri]
I have addressed
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063494#comment-17063494
]
Ayush Saxena commented on HDFS-15196:
-
Thanx Everyone. Seems fine. A minor doubt :
Do we need to
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063473#comment-17063473
]
Íñigo Goiri commented on HDFS-15196:
Not sure what's wrong with Yetus...
[^HDFS-15196.009.patch]
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17063007#comment-17063007
]
Fengnan Li commented on HDFS-15196:
---
[~elgoiri] somehow there is no further comment from Hadoop QA
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062700#comment-17062700
]
Fengnan Li commented on HDFS-15196:
---
Reuploaded [^HDFS-15196.009.patch] to trigger the build and test
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17062053#comment-17062053
]
Fengnan Li commented on HDFS-15196:
---
[~elgoiri] I am not sure it is related since the failure is
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061821#comment-17061821
]
Íñigo Goiri commented on HDFS-15196:
The failed test in TestRouterRpc looks suspicious.
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061448#comment-17061448
]
Hadoop QA commented on HDFS-15196:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061404#comment-17061404
]
Fengnan Li commented on HDFS-15196:
---
Uploaded [^HDFS-15196.008.patch] to fix checkstyle.
> RBF:
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061401#comment-17061401
]
Hadoop QA commented on HDFS-15196:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061370#comment-17061370
]
Fengnan Li commented on HDFS-15196:
---
Thanks for the review [~elgoiri] I added another logic handling
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061261#comment-17061261
]
Hadoop QA commented on HDFS-15196:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061234#comment-17061234
]
Íñigo Goiri commented on HDFS-15196:
That looks more complete.
As the unit test is a little limited
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061220#comment-17061220
]
Fengnan Li commented on HDFS-15196:
---
[~elgoiri] [~ayushtkn] Added slightly more complex control logic
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051493#comment-17051493
]
Íñigo Goiri commented on HDFS-15196:
Thanks [~fengnanli] for the clarification.
Yes, I agree we
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17051204#comment-17051204
]
Jinglun commented on HDFS-15196:
Hi [~fengnanli], thanks your nice work !
{quote}I guess there is a
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050523#comment-17050523
]
Fengnan Li commented on HDFS-15196:
---
Agree the order should be preserved. Just to be clear, I list out
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050483#comment-17050483
]
Íñigo Goiri commented on HDFS-15196:
[~LiJinglun] can you take a look at this?
I agree with
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049928#comment-17049928
]
Fengnan Li commented on HDFS-15196:
---
[~elgoiri] Without the fix the test will fail. Actually,
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049898#comment-17049898
]
Ayush Saxena commented on HDFS-15196:
-
On a thought, the namenode returns entries in sorted order, if
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049795#comment-17049795
]
Hadoop QA commented on HDFS-15196:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049766#comment-17049766
]
Íñigo Goiri commented on HDFS-15196:
Thanks [~fengnanli] for the update, that looks better.
Can you
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049746#comment-17049746
]
Fengnan Li commented on HDFS-15196:
---
Thanks for the answer [~elgoiri] Uploaded [^HDFS-15196.005.patch]
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17049590#comment-17049590
]
Íñigo Goiri commented on HDFS-15196:
Regarding the Namenode overrides, we have addNamenodeOverrides
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048247#comment-17048247
]
Hadoop QA commented on HDFS-15196:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048232#comment-17048232
]
Fengnan Li commented on HDFS-15196:
---
Thanks for the review [~elgoiri] Uploaded [^HDFS-15196.004.patch]
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048128#comment-17048128
]
Íñigo Goiri commented on HDFS-15196:
* TestRouterRpcMultiDestination looks suspicious. Actually, it's
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17048016#comment-17048016
]
Hadoop QA commented on HDFS-15196:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047968#comment-17047968
]
Fengnan Li commented on HDFS-15196:
---
Reupload [^HDFS-15196.003.patch] to trigger the tests since those
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047943#comment-17047943
]
Hadoop QA commented on HDFS-15196:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047899#comment-17047899
]
Fengnan Li commented on HDFS-15196:
---
Fix checkstyle in [^HDFS-15196.003.patch]
> RBF: RouterRpcServer
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047894#comment-17047894
]
Hadoop QA commented on HDFS-15196:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047843#comment-17047843
]
Fengnan Li commented on HDFS-15196:
---
Thanks [~elgoiri] [~ayushtkn] for the review! Uploaded patch 002
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047180#comment-17047180
]
Ayush Saxena commented on HDFS-15196:
-
Thanx [~fengnanli] for the patch.
You can add a test to may
[
https://issues.apache.org/jira/browse/HDFS-15196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17047178#comment-17047178
]
Íñigo Goiri commented on HDFS-15196:
The tests don't look very happy.
Minor comments:
* Avoid changes
54 matches
Mail list logo
