[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17204000#comment-17204000
]
Wei-Chiu Chuang commented on HDFS-15415:
+1
> Reduce locking in Datanode DirectoryScanner
>
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203863#comment-17203863
]
Hadoop QA commented on HDFS-15415:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203565#comment-17203565
]
Hadoop QA commented on HDFS-15415:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203511#comment-17203511
]
Stephen O'Donnell commented on HDFS-15415:
--
Updated a patch for branch-3.1. With this patch on
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203498#comment-17203498
]
Stephen O'Donnell commented on HDFS-15415:
--
[~weichiu] Thanks for committing. There is conflict
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17203483#comment-17203483
]
Wei-Chiu Chuang commented on HDFS-15415:
Ok +1. Committed the patch into branch-3.2
> Reduce
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201342#comment-17201342
]
Stephen O'Donnell commented on HDFS-15415:
--
Thanks [~weichiu] - I ran both the failing test
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17201272#comment-17201272
]
Wei-Chiu Chuang commented on HDFS-15415:
The code looks good. I wanted to verify that test
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200308#comment-17200308
]
Hadoop QA commented on HDFS-15415:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200128#comment-17200128
]
Hadoop QA commented on HDFS-15415:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17200013#comment-17200013
]
Stephen O'Donnell commented on HDFS-15415:
--
I committed the branch-3.3 patch and upload a new
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199693#comment-17199693
]
Wei-Chiu Chuang commented on HDFS-15415:
+1. Sorry I reviewed but forgot to comment here.
>
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199691#comment-17199691
]
Stephen O'Donnell commented on HDFS-15415:
--
I will commit the branch-3.3 patch tomorrow if there
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17198294#comment-17198294
]
Hadoop QA commented on HDFS-15415:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197710#comment-17197710
]
Stephen O'Donnell commented on HDFS-15415:
--
All tests passed locally.
I have committed to trunk
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17197248#comment-17197248
]
Wei-Chiu Chuang commented on HDFS-15415:
LGTM can you verify the failed tests are unrelated?
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196867#comment-17196867
]
Hadoop QA commented on HDFS-15415:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196477#comment-17196477
]
Hadoop QA commented on HDFS-15415:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196232#comment-17196232
]
Stephen O'Donnell commented on HDFS-15415:
--
[~weichiu] Thanks for the review. You are correct -
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196185#comment-17196185
]
Wei-Chiu Chuang commented on HDFS-15415:
{code}
try (AutoCloseableLock lock =
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17196162#comment-17196162
]
Hadoop QA commented on HDFS-15415:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194199#comment-17194199
]
Hadoop QA commented on HDFS-15415:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194195#comment-17194195
]
Stephen O'Donnell commented on HDFS-15415:
--
This patch needs rebased against current trunk.
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141174#comment-17141174
]
Hadoop QA commented on HDFS-15415:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17141119#comment-17141119
]
Stephen O'Donnell commented on HDFS-15415:
--
The 002 patch removes the lock from all the logic
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140812#comment-17140812
]
Hadoop QA commented on HDFS-15415:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140779#comment-17140779
]
Stephen O'Donnell commented on HDFS-15415:
--
If a block is RBW or RUR before the snapshot of
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140699#comment-17140699
]
hemanthboyina commented on HDFS-15415:
--
thanks [~sodonnell] for your analysis
after taking the
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140477#comment-17140477
]
Stephen O'Donnell commented on HDFS-15415:
--
I have annotated the main loop the DirectoryScanner
[
https://issues.apache.org/jira/browse/HDFS-15415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17140397#comment-17140397
]
Stephen O'Donnell commented on HDFS-15415:
--
Uploaded initial patch to remove the unnecessary
30 matches
Mail list logo
