[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17273259#comment-17273259
]
Lisheng Sun commented on HDFS-15661:
Commited to trunk.
Thanks [~LiJinglun] for your report and
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271747#comment-17271747
]
Wei-Chiu Chuang commented on HDFS-15661:
LGTM
> The DeadNodeDetector shouldn't be shared by
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271382#comment-17271382
]
Lisheng Sun commented on HDFS-15661:
+1 on
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271354#comment-17271354
]
Hadoop QA commented on HDFS-15661:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271212#comment-17271212
]
Jinglun commented on HDFS-15661:
Hi [~leosun08], thanks your comments ! Fix checkstyle and submit v05.
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17271048#comment-17271048
]
Lisheng Sun commented on HDFS-15661:
Thank [~LiJinglun] for nice fixing,according to the way we
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270916#comment-17270916
]
Hadoop QA commented on HDFS-15661:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17270862#comment-17270862
]
Jinglun commented on HDFS-15661:
Submit v04 removing the redundant temporary variable 'detector'. Hi
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266795#comment-17266795
]
Jinglun commented on HDFS-15661:
The failed test is not related.
> The DeadNodeDetector shouldn't be
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266705#comment-17266705
]
Hadoop QA commented on HDFS-15661:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266693#comment-17266693
]
Jinglun commented on HDFS-15661:
Submit v03 fixing checkstyle. Hi [~weichiu] [~leosun08] could you help
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1721#comment-1721
]
Hadoop QA commented on HDFS-15661:
--
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17266059#comment-17266059
]
Jinglun commented on HDFS-15661:
Hi [~weichiu], thanks your comments !
{quote}It seems like a good idea
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17265745#comment-17265745
]
Wei-Chiu Chuang commented on HDFS-15661:
I'm not familiar with the dead node detector -- it's a
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17264829#comment-17264829
]
Wei-Chiu Chuang commented on HDFS-15661:
[~leosun08] do you have cycles to review this patch for
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17223026#comment-17223026
]
Hadoop QA commented on HDFS-15661:
--
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-15661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17222887#comment-17222887
]
Jinglun commented on HDFS-15661:
Hi [~leosun08] [~linyiqun] [~hexiaoqiao], do you have time to help
17 matches
Mail list logo