[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2023-12-12 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795848#comment-17795848 ] ASF GitHub Bot commented on HDFS-16083: --- hadoop-yetus commented on PR #6343: URL:

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795625#comment-17795625 ] ASF GitHub Bot commented on HDFS-16083: --- hadoop-yetus commented on PR #6343: URL:

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795615#comment-17795615 ] ASF GitHub Bot commented on HDFS-16083: --- hadoop-yetus commented on PR #6343: URL:

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795583#comment-17795583 ] ASF GitHub Bot commented on HDFS-16083: --- ThinkerLei commented on PR #6343: URL:

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2023-12-11 Thread lei w (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795580#comment-17795580 ] lei w commented on HDFS-16083: -- [~tomscut] Is this reasonable? > Forbid Observer NameNode trigger active

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795575#comment-17795575 ] ASF GitHub Bot commented on HDFS-16083: --- tomscut commented on PR #6343: URL:

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795570#comment-17795570 ] ASF GitHub Bot commented on HDFS-16083: --- ThinkerLei commented on PR #6343: URL:

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795471#comment-17795471 ] ASF GitHub Bot commented on HDFS-16083: --- hadoop-yetus commented on PR #6343: URL:

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2023-12-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17795376#comment-17795376 ] ASF GitHub Bot commented on HDFS-16083: --- ThinkerLei opened a new pull request, #6343: URL:

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2021-07-14 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17380633#comment-17380633 ] Hadoop QA commented on HDFS-16083: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2021-06-30 Thread lei w (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17372039#comment-17372039 ] lei w commented on HDFS-16083: -- Thanks [~LiJinglun] reply. Take your suggestion and make some changes in v05

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2021-06-30 Thread Jinglun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371915#comment-17371915 ] Jinglun commented on HDFS-16083: Hi [~lei w], thanks your patch, some comments. In EditLogTailer.java:

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2021-06-29 Thread lei w (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17371403#comment-17371403 ] lei w commented on HDFS-16083: -- Add test in HDFS-16083.003.patch > Forbid Observer NameNode trigger

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2021-06-23 Thread lei w (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368017#comment-17368017 ] lei w commented on HDFS-16083: -- Thanks [~LiJinglun] reply ,I will add more information and add unit tests

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2021-06-23 Thread Jinglun (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17368012#comment-17368012 ] Jinglun commented on HDFS-16083: Hi [~lei w], thanks your report ! The description makes sense to me. I

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2021-06-23 Thread lei w (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367906#comment-17367906 ] lei w commented on HDFS-16083: -- [~ayushsaxena] , [~LiJinglun] anyone have any suggestions? > Forbid

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2021-06-22 Thread tomscut (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367866#comment-17367866 ] tomscut commented on HDFS-16083: Thanks [~lei w] for your update. The patch HDFS-16083.002.patch looks

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2021-06-22 Thread lei w (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367858#comment-17367858 ] lei w commented on HDFS-16083: -- Thanks [~tomscut] comment. Changed and add new patch HDFS-16083.002.patch >

[jira] [Commented] (HDFS-16083) Forbid Observer NameNode trigger active namenode log roll

2021-06-22 Thread tomscut (Jira)
[ https://issues.apache.org/jira/browse/HDFS-16083?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17367838#comment-17367838 ] tomscut commented on HDFS-16083: [~lei w] This change makes sense. But I suggest changing "isObserver" to