[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13721320#comment-13721320
]
Colin Patrick McCabe commented on HDFS-4979:
Thanks for addressing HADOOP-9770.
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13719824#comment-13719824
]
Jing Zhao commented on HDFS-4979:
-
The new patch looks pretty good to me. +1 for the patch.
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13719827#comment-13719827
]
Suresh Srinivas commented on HDFS-4979:
---
Given that this is a change that should go
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13719829#comment-13719829
]
Suresh Srinivas commented on HDFS-4979:
---
[~cmccabe] Please look at this patch and
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13719944#comment-13719944
]
Colin Patrick McCabe commented on HDFS-4979:
I'm still concerned about the
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720192#comment-13720192
]
Jing Zhao commented on HDFS-4979:
-
bq. Also I don't think CacheEntry#state needs to be
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720202#comment-13720202
]
Suresh Srinivas commented on HDFS-4979:
---
bq. Also I don't think CacheEntry#state
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13720203#comment-13720203
]
Suresh Srinivas commented on HDFS-4979:
---
BTW, yesterday I meant to post this comment,
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718557#comment-13718557
]
Suresh Srinivas commented on HDFS-4979:
---
Here is a quick bench mark I did to test the
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13718938#comment-13718938
]
Suresh Srinivas commented on HDFS-4979:
---
ClientCacheEntry/ClientCacheEntryWithPayload
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13719111#comment-13719111
]
Colin Patrick McCabe commented on HDFS-4979:
looks good overall.
{code}
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13719132#comment-13719132
]
Hadoop QA commented on HDFS-4979:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13719204#comment-13719204
]
Hadoop QA commented on HDFS-4979:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13715471#comment-13715471
]
Suresh Srinivas commented on HDFS-4979:
---
I have been discussing how to size the retry
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13714547#comment-13714547
]
Suresh Srinivas commented on HDFS-4979:
---
bq. It seems like a bug to log 2 audit
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13714597#comment-13714597
]
Hadoop QA commented on HDFS-4979:
-
{color:green}+1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713403#comment-13713403
]
Hadoop QA commented on HDFS-4979:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713559#comment-13713559
]
Hadoop QA commented on HDFS-4979:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13714308#comment-13714308
]
Hadoop QA commented on HDFS-4979:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13714348#comment-13714348
]
Chris Nauroth commented on HDFS-4979:
-
{code}
private static boolean
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712053#comment-13712053
]
Chris Nauroth commented on HDFS-4979:
-
# In reference to this code for synchronization
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712055#comment-13712055
]
Hadoop QA commented on HDFS-4979:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13712562#comment-13712562
]
Suresh Srinivas commented on HDFS-4979:
---
bq. notifyAll...
Chris, you are right. Nice
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713054#comment-13713054
]
Jing Zhao commented on HDFS-4979:
-
1. For FSNamesystem#renameTo(String, String,
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13713358#comment-13713358
]
Hadoop QA commented on HDFS-4979:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711827#comment-13711827
]
Hadoop QA commented on HDFS-4979:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13711961#comment-13711961
]
Hadoop QA commented on HDFS-4979:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710170#comment-13710170
]
Konstantin Shvachko commented on HDFS-4979:
---
Cross posting from HDFS-4942 as this
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710186#comment-13710186
]
Chris Nauroth commented on HDFS-4979:
-
Hi, Suresh. The approach in the patch is
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13710444#comment-13710444
]
Suresh Srinivas commented on HDFS-4979:
---
bq. Would it make sense then to generalize
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13708921#comment-13708921
]
Hadoop QA commented on HDFS-4979:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709105#comment-13709105
]
Suresh Srinivas commented on HDFS-4979:
---
I noticed that where I am setting boolean
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13709179#comment-13709179
]
Konstantin Shvachko commented on HDFS-4979:
---
Suresh, do you mind answering the
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13705625#comment-13705625
]
Hadoop QA commented on HDFS-4979:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13705715#comment-13705715
]
Hadoop QA commented on HDFS-4979:
-
{color:red}-1 overall{color}. Here are the results of
[
https://issues.apache.org/jira/browse/HDFS-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13705352#comment-13705352
]
Fengdong Yu commented on HDFS-4979:
---
This is a good point, and an important feature.
36 matches
Mail list logo
