[jira] [Commented] (HDFS-6328) Simplify code in FSDirectory

2014-05-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993399#comment-13993399 ] Hadoop QA commented on HDFS-6328: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6328) Simplify code in FSDirectory

2014-05-14 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993823#comment-13993823 ] Haohui Mai commented on HDFS-6328: -- Attaching v4 patch to address Jing's comments.

[jira] [Commented] (HDFS-6328) Simplify code in FSDirectory

2014-05-13 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13993786#comment-13993786 ] Jing Zhao commented on HDFS-6328: - The latest patch looks good to me. Only one nit: the

[jira] [Commented] (HDFS-6328) Simplify code in FSDirectory

2014-05-10 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13994087#comment-13994087 ] Hadoop QA commented on HDFS-6328: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6328) Simplify code in FSDirectory

2014-05-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990382#comment-13990382 ] Hadoop QA commented on HDFS-6328: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6328) Simplify code in FSDirectory

2014-05-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13991157#comment-13991157 ] Hadoop QA commented on HDFS-6328: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6328) Simplify code in FSDirectory

2014-05-06 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13991268#comment-13991268 ] Haohui Mai commented on HDFS-6328: -- Thanks [~daryn] for looking at this. The v2 patch

[jira] [Commented] (HDFS-6328) Simplify code in FSDirectory

2014-05-06 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13991271#comment-13991271 ] Jing Zhao commented on HDFS-6328: - bq. Is there a reason why this loop needed to become

[jira] [Commented] (HDFS-6328) Simplify code in FSDirectory

2014-05-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989931#comment-13989931 ] Hadoop QA commented on HDFS-6328: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6328) Simplify code in FSDirectory

2014-05-05 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989971#comment-13989971 ] Haohui Mai commented on HDFS-6328: -- The test failure is unrelated. I ran the test locally

[jira] [Commented] (HDFS-6328) Simplify code in FSDirectory

2014-05-05 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13989982#comment-13989982 ] Jing Zhao commented on HDFS-6328: - The patch looks pretty good to me. Thanks for the

[jira] [Commented] (HDFS-6328) Simplify code in FSDirectory

2014-05-05 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990058#comment-13990058 ] Daryn Sharp commented on HDFS-6328: --- As a general statement, I'm not sure there's a lot

[jira] [Commented] (HDFS-6328) Simplify code in FSDirectory

2014-05-05 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13990066#comment-13990066 ] Haohui Mai commented on HDFS-6328: -- The main motivation of this jira is to perform