[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041851#comment-14041851 ] Hudson commented on HDFS-6562: -- SUCCESS: Integrated in Hadoop-trunk-Commit #5757 (See

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041990#comment-14041990 ] Hudson commented on HDFS-6562: -- SUCCESS: Integrated in Hadoop-Yarn-trunk #593 (See

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042144#comment-14042144 ] Hudson commented on HDFS-6562: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #1784 (See

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14042228#comment-14042228 ] Hudson commented on HDFS-6562: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #1811 (See

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-23 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041065#comment-14041065 ] Jing Zhao commented on HDFS-6562: - The new patch looks pretty good to me. +1 [~szetszwo],

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-23 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041422#comment-14041422 ] Tsz Wo Nicholas Sze commented on HDFS-6562: --- Patch looks good. Some comments: -

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-23 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041440#comment-14041440 ] Haohui Mai commented on HDFS-6562: -- Uploaded v6 patch to address [~szetszwo]'s comments.

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-23 Thread Tsz Wo Nicholas Sze (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041507#comment-14041507 ] Tsz Wo Nicholas Sze commented on HDFS-6562: --- Thanks for the explanation.

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14041656#comment-14041656 ] Hadoop QA commented on HDFS-6562: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-22 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040064#comment-14040064 ] Haohui Mai commented on HDFS-6562: -- Thanks [~jingzhao] and [~daryn] for the reviews.

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14040100#comment-14040100 ] Hadoop QA commented on HDFS-6562: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-20 Thread Daryn Sharp (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039426#comment-14039426 ] Daryn Sharp commented on HDFS-6562: --- Are you sure this can't be a

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-20 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039444#comment-14039444 ] Jing Zhao commented on HDFS-6562: - Thanks for the refactoring, Haohui! Just finished

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-20 Thread Jing Zhao (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14039474#comment-14039474 ] Jing Zhao commented on HDFS-6562: - Comments for the remaining changes: # I guess we can

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038212#comment-14038212 ] Hadoop QA commented on HDFS-6562: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14038457#comment-14038457 ] Hadoop QA commented on HDFS-6562: - {color:green}+1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6562) Refactor rename() in FSDirectory

2014-06-18 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14036814#comment-14036814 ] Hadoop QA commented on HDFS-6562: - {color:red}-1 overall{color}. Here are the results of