[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126011#comment-14126011 ] Hadoop QA commented on HDFS-6981: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-08 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126424#comment-14126424 ] Hadoop QA commented on HDFS-6981: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-08 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126480#comment-14126480 ] Arpit Agarwal commented on HDFS-6981: - All test failures look unrelated? DN upgrade

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-08 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14126539#comment-14126539 ] Haohui Mai commented on HDFS-6981: -- +1 DN upgrade with layout version change should not

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-07 Thread James Thomas (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124958#comment-14124958 ] James Thomas commented on HDFS-6981: +1, looks good to me. Getting a 404 when I try to

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125108#comment-14125108 ] Hadoop QA commented on HDFS-6981: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-07 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14125200#comment-14125200 ] Arpit Agarwal commented on HDFS-6981: - bq. -1 findbugs. The patch appears to introduce

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-06 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124602#comment-14124602 ] Arpit Agarwal commented on HDFS-6981: - Latest test failures are unrelated to the patch.

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-06 Thread James Thomas (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124731#comment-14124731 ] James Thomas commented on HDFS-6981: {code} + if

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-06 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124785#comment-14124785 ] Hadoop QA commented on HDFS-6981: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122513#comment-14122513 ] Hadoop QA commented on HDFS-6981: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-05 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122555#comment-14122555 ] Arpit Agarwal commented on HDFS-6981: - So removing 'previous' after a rolling upgrade

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-05 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123413#comment-14123413 ] Arpit Agarwal commented on HDFS-6981: - Lacking an explicit finalize command for rolling

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-05 Thread James Thomas (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14123471#comment-14123471 ] James Thomas commented on HDFS-6981: The marker file sounds like the best solution to

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124258#comment-14124258 ] Hadoop QA commented on HDFS-6981: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-05 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14124342#comment-14124342 ] Hadoop QA commented on HDFS-6981: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14120995#comment-14120995 ] Hadoop QA commented on HDFS-6981: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-04 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14121921#comment-14121921 ] Haohui Mai commented on HDFS-6981: -- {code} + /** + * Current layout version for

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-04 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14121945#comment-14121945 ] Arpit Agarwal commented on HDFS-6981: - Thanks for reviewing Haohui. Let me look into

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-04 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122205#comment-14122205 ] Arpit Agarwal commented on HDFS-6981: - Also the override was avoided by adding the new

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-04 Thread James Thomas (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122262#comment-14122262 ] James Thomas commented on HDFS-6981: [~arpitagarwal], thanks for the patch. A couple

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-04 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122268#comment-14122268 ] Hadoop QA commented on HDFS-6981: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-04 Thread James Thomas (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122378#comment-14122378 ] James Thomas commented on HDFS-6981: bq. Not an issue. If there was no layout version

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-04 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14122384#comment-14122384 ] Arpit Agarwal commented on HDFS-6981: - I think that will be fine - heartbeats are sent

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-03 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14120891#comment-14120891 ] Arpit Agarwal commented on HDFS-6981: - Also thanks to James for finding this issue and

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-03 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14120894#comment-14120894 ] Hadoop QA commented on HDFS-6981: - {color:red}-1 overall{color}. Here are the results of

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-01 Thread James Thomas (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14117782#comment-14117782 ] James Thomas commented on HDFS-6981: [~arpitagarwal], thanks for filing this. Shouldn't

[jira] [Commented] (HDFS-6981) DN upgrade with layout version change should not use trash

2014-09-01 Thread Arpit Agarwal (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14117787#comment-14117787 ] Arpit Agarwal commented on HDFS-6981: - The fix version can't be 2.6.0 since we have no