[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-26 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14292210#comment-14292210 ] Konstantin Shvachko commented on HDFS-7659: --- No problem. I was just trying to fin

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-25 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291321#comment-14291321 ] Yi Liu commented on HDFS-7659: -- Thanks [~shv] for the review and commit. {quote} Can I ask yo

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291135#comment-14291135 ] Hudson commented on HDFS-7659: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk #2035 (See [htt

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291122#comment-14291122 ] Hudson commented on HDFS-7659: -- FAILURE: Integrated in Hadoop-Mapreduce-trunk-Java8 #85 (See

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291110#comment-14291110 ] Hudson commented on HDFS-7659: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk-Java8 #81 (See [http

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291106#comment-14291106 ] Hudson commented on HDFS-7659: -- SUCCESS: Integrated in Hadoop-Hdfs-trunk #2016 (See [https://

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291052#comment-14291052 ] Hudson commented on HDFS-7659: -- FAILURE: Integrated in Hadoop-Yarn-trunk #818 (See [https://b

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-25 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14291049#comment-14291049 ] Hudson commented on HDFS-7659: -- FAILURE: Integrated in Hadoop-Yarn-trunk-Java8 #84 (See [http

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-24 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290889#comment-14290889 ] Hudson commented on HDFS-7659: -- FAILURE: Integrated in Hadoop-trunk-Commit #6924 (See [https:

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-23 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14290329#comment-14290329 ] Konstantin Shvachko commented on HDFS-7659: --- +1. Looks good. Can I ask you to ad

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289066#comment-14289066 ] Hadoop QA commented on HDFS-7659: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288744#comment-14288744 ] Hadoop QA commented on HDFS-7659: - {color:red}-1 overall{color}. Here are the results of t

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-22 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288576#comment-14288576 ] Yi Liu commented on HDFS-7659: -- Wait, I need to give a new patch to add it to DFSClient... >

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-22 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288570#comment-14288570 ] Yi Liu commented on HDFS-7659: -- Sure, let me do it. > We should check the new length of trunc

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-22 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288572#comment-14288572 ] Yi Liu commented on HDFS-7659: -- Sure, let me do it. > We should check the new length of trunc

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-22 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288571#comment-14288571 ] Yi Liu commented on HDFS-7659: -- Sure, let me do it. > We should check the new length of trunc

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-22 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288549#comment-14288549 ] Konstantin Shvachko commented on HDFS-7659: --- Makes sense, Yi. Then we can *also*

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-22 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288529#comment-14288529 ] Yi Liu commented on HDFS-7659: -- {quote} Why don't we just add the negative check to the condit

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-22 Thread Yi Liu (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288499#comment-14288499 ] Yi Liu commented on HDFS-7659: -- Thanks Colin and Konstantin, will update the patch later. > W

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-22 Thread Konstantin Shvachko (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288491#comment-14288491 ] Konstantin Shvachko commented on HDFS-7659: --- Agreed about Preconditions. Why don'

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-22 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288237#comment-14288237 ] Colin Patrick McCabe commented on HDFS-7659: Thanks for the patch. A few comme

[jira] [Commented] (HDFS-7659) We should check the new length of truncate can't be a negative value.

2015-01-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-7659?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14287575#comment-14287575 ] Hadoop QA commented on HDFS-7659: - {color:red}-1 overall{color}. Here are the results of t