[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-12 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15002551#comment-15002551 ] Haohui Mai commented on HDFS-9328: -- +1. I'll commit it shortly. > Formalize coding stand

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-11 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001230#comment-15001230 ] Haohui Mai commented on HDFS-9328: -- Sounds good to me. I think it also makes sense to mak

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-11 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001212#comment-15001212 ] Steve Loughran commented on HDFS-9328: -- I'd put the ASF header back. All the other .md

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-11 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15001146#comment-15001146 ] Haohui Mai commented on HDFS-9328: -- LGTM. [~steve_l] do you have any more comments? > For

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-11 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000879#comment-15000879 ] Hadoop QA commented on HDFS-9328: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-11 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15000646#comment-15000646 ] James Clampffer commented on HDFS-9328: --- "The markdown doesn't seem to be rendered co

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-10 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14999689#comment-14999689 ] Haohui Mai commented on HDFS-9328: -- The markdown doesn't seem to be rendered correctly und

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14997466#comment-14997466 ] Hadoop QA commented on HDFS-9328: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-09 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14996985#comment-14996985 ] Hadoop QA commented on HDFS-9328: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote ||

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-06 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994229#comment-14994229 ] Steve Loughran commented on HDFS-9328: -- think it's Power. Nobody owns up to Itanium as

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-06 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994193#comment-14994193 ] James Clampffer commented on HDFS-9328: --- Good idea on the markdown. I'd really like

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-06 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14994179#comment-14994179 ] James Clampffer commented on HDFS-9328: --- I'll change it to markdown as you and [~whea

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-06 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14993777#comment-14993777 ] Steve Loughran commented on HDFS-9328: -- +1 for markdown, consider putting into Hadoop

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-06 Thread Bob Hansen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14993686#comment-14993686 ] Bob Hansen commented on HDFS-9328: -- I'm sure you don't disagree with the principle in (4),

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-05 Thread Haohui Mai (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992486#comment-14992486 ] Haohui Mai commented on HDFS-9328: -- It's better to have the file in markdown format, prefe

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-05 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992445#comment-14992445 ] James Clampffer commented on HDFS-9328: --- I'm fine with relaxing the clang-format rule

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-05 Thread Bob Hansen (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14992415#comment-14992415 ] Bob Hansen commented on HDFS-9328: -- I am not keen on tying the coding standards to a tool

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-11-03 Thread James Clampffer (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14987448#comment-14987448 ] James Clampffer commented on HDFS-9328: --- Right now Haohui wants to use google's C++ s

[jira] [Commented] (HDFS-9328) Formalize coding standards for libhdfs++ and put them in a README.txt

2015-10-30 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14982268#comment-14982268 ] Steve Loughran commented on HDFS-9328: -- Are you proposing a different cpp guide from t