[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026984#comment-15026984
]
Wei-Chiu Chuang commented on HDFS-9451:
---
Most failures are due to file permission issue:
Error while
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027076#comment-15027076
]
Wei-Chiu Chuang commented on HDFS-9451:
---
I am not seeing these test failures locally, by the way.
>
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027522#comment-15027522
]
Hadoop QA commented on HDFS-9451:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027569#comment-15027569
]
Haohui Mai commented on HDFS-9451:
--
LGTM. +1. Committing.
> TestFsPermission#testDeprecatedUmask is
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15027567#comment-15027567
]
Wei-Chiu Chuang commented on HDFS-9451:
---
The findbugs warning is likely a bug in Yetus. The variable
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15026085#comment-15026085
]
Hadoop QA commented on HDFS-9451:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025250#comment-15025250
]
Chang Li commented on HDFS-9451:
Well... then let's do what [~wheat9] said, to totally remove the support
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025309#comment-15025309
]
Hadoop QA commented on HDFS-9451:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025440#comment-15025440
]
Haohui Mai commented on HDFS-9451:
--
+1 pending jenkins
> TestFsPermission#testDeprecatedUmask is broken
>
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025433#comment-15025433
]
Chang Li commented on HDFS-9451:
Thanks for update! lgtm, +1(non binding)
>
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025014#comment-15025014
]
Chang Li commented on HDFS-9451:
[~wheat9], I have opened HADOOP-12595 to track the whole work of remove
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025015#comment-15025015
]
Chang Li commented on HDFS-9451:
[~wheat9], I have opened HADOOP-12595 to track the whole work of remove
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024754#comment-15024754
]
Chang Li commented on HDFS-9451:
Thanks [~jojochuang] for working on this! The test changes are correct
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024774#comment-15024774
]
Wei-Chiu Chuang commented on HDFS-9451:
---
Hi [~lichangleo] thanks for the review.
Is the intention
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024789#comment-15024789
]
Chang Li commented on HDFS-9451:
Hi [~jojochuang], though it could be removed entirely for 3.0, but the
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024879#comment-15024879
]
Chris Nauroth commented on HDFS-9451:
-
I've asked for some clarification on HADOOP-12294 about what
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025003#comment-15025003
]
Haohui Mai commented on HDFS-9451:
--
{code}
public static final String DEPRECATED_UMASK_LABEL =
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025110#comment-15025110
]
Haohui Mai commented on HDFS-9451:
--
It makes sense to remove it from {{setUMask}} as well since it is a
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025116#comment-15025116
]
Wei-Chiu Chuang commented on HDFS-9451:
---
I am thinking to remove all usages of DEPRECATED_UMASK_LABEL
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025124#comment-15025124
]
Chang Li commented on HDFS-9451:
Since this jira only intends to fix test, it's better to avoid touching
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15025183#comment-15025183
]
Haohui Mai commented on HDFS-9451:
--
The issue is trivial enough thus I see little values of having
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024266#comment-15024266
]
Tsuyoshi Ozawa commented on HDFS-9451:
--
Targeting this to 3.0.0 since HADOOP-12294 is only for 3.0.0.
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024273#comment-15024273
]
Tsuyoshi Ozawa commented on HDFS-9451:
--
LGTM, pending for Jenkins.
>
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15024352#comment-15024352
]
Hadoop QA commented on HDFS-9451:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023336#comment-15023336
]
Wei-Chiu Chuang commented on HDFS-9451:
---
Hi [~wheat9] [~zxu] [~jlowe] [~lichangleo],
I would like to
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023416#comment-15023416
]
Hadoop QA commented on HDFS-9451:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDFS-9451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15023926#comment-15023926
]
Wei-Chiu Chuang commented on HDFS-9451:
---
TestPermission#testBackwardCompatibility is also broken by
27 matches
Mail list logo
