[jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor

2016-03-21 Thread Lin Yiqun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15205621#comment-15205621 ] Lin Yiqun commented on HDFS-9951: - Thanks [~cmccabe] for commit! > Use string constants for XML tags in

[jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor

2016-03-21 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204956#comment-15204956 ] Hudson commented on HDFS-9951: -- FAILURE: Integrated in Hadoop-trunk-Commit #9483 (See

[jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor

2016-03-21 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15204862#comment-15204862 ] Colin Patrick McCabe commented on HDFS-9951: Thanks for fixing the patch. +1 > Use string

[jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor

2016-03-20 Thread Lin Yiqun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15203612#comment-15203612 ] Lin Yiqun commented on HDFS-9951: - The remained failed unit tests look not related. > Use string constants

[jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor

2016-03-19 Thread Lin Yiqun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15200798#comment-15200798 ] Lin Yiqun commented on HDFS-9951: - I have looked the log, the test {{TestOfflineImageViewer}} was a timed

[jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor

2016-03-19 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15201986#comment-15201986 ] Colin Patrick McCabe commented on HDFS-9951: Please run the test on your local computer and

[jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor

2016-03-19 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197972#comment-15197972 ] Colin Patrick McCabe commented on HDFS-9951: unit test failures are related > Use string

[jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor

2016-03-19 Thread Lin Yiqun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15199318#comment-15199318 ] Lin Yiqun commented on HDFS-9951: - The failed unit test

[jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor

2016-03-19 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202634#comment-15202634 ] Hadoop QA commented on HDFS-9951: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor

2016-03-19 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1526#comment-1526 ] Colin Patrick McCabe commented on HDFS-9951: Hi [~linyiqun], have you looked at the log to see

[jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor

2016-03-18 Thread Lin Yiqun (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15202456#comment-15202456 ] Lin Yiqun commented on HDFS-9951: - Sorry for [~cmccabe], I tested in my local. There was a actual error. I

[jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor

2016-03-16 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15197148#comment-15197148 ] Hadoop QA commented on HDFS-9951: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor

2016-03-15 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195795#comment-15195795 ] Colin Patrick McCabe commented on HDFS-9951: Thanks for working on this. Can you put the

[jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor

2016-03-15 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15195069#comment-15195069 ] Hadoop QA commented on HDFS-9951: - | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-9951) Use string constants for XML tags in OfflineImageReconstructor

2016-03-14 Thread Colin Patrick McCabe (JIRA)
[ https://issues.apache.org/jira/browse/HDFS-9951?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193531#comment-15193531 ] Colin Patrick McCabe commented on HDFS-9951: It seems reasonable to me. It seems like