[ 
https://issues.apache.org/jira/browse/HDFS-9581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tianyin Xu updated HDFS-9581:
-----------------------------
    Description: 
The current default value of config parameter,{{dfs.namenode.backup.address}}, 
is 
{{localhost:50100}}

while in 
[hdfs-default.xml|https://hadoop.apache.org/docs/r2.6.2/hadoop-project-dist/hadoop-hdfs/hdfs-default.xml],
 it is 
{{0.0.0.0:50100}}

We should make the values consistent, as {{localhost}} has very different 
meanings from {{0.0.0.0}}. Since all the server daemons (e.g., 
{{dfs.namenode.backup.http-address}}, {{dfs.datanode.address}}) bind to 
{{0.0.0.0}}. I guess {{dfs.namenode.backup.address}} should also be 
{{0.0.0.0}}, unless there are some protection concerns (in this case we can 
change hdfs-default.xml).

*Patch (DFSConfigKeys.java)*
{code}
--- DFSConfigKeys.java  2015-12-19 10:39:38.982212865 -0800
+++ DFSConfigKeys.java  2015-12-19 10:40:10.830213622 -0800
@@ -132,7 +132,7 @@
   public static final String  DFS_DATANODE_RESTART_REPLICA_EXPIRY_KEY = 
"dfs.datanode.restart.replica.expiration";
   public static final long    DFS_DATANODE_RESTART_REPLICA_EXPIRY_DEFAULT = 50;
   public static final String  DFS_NAMENODE_BACKUP_ADDRESS_KEY = 
"dfs.namenode.backup.address";
-  public static final String  DFS_NAMENODE_BACKUP_ADDRESS_DEFAULT = 
"localhost:50100";
+  public static final String  DFS_NAMENODE_BACKUP_ADDRESS_DEFAULT = 
"0.0.0.0:50100";
   public static final String  DFS_NAMENODE_BACKUP_HTTP_ADDRESS_KEY = 
"dfs.namenode.backup.http-address";
   public static final String  DFS_NAMENODE_BACKUP_HTTP_ADDRESS_DEFAULT = 
"0.0.0.0:50105";
   public static final String  DFS_NAMENODE_BACKUP_SERVICE_RPC_ADDRESS_KEY = 
"dfs.namenode.backup.dnrpc-address";
{code}

  was:
The current default value of config parameter,{{dfs.namenode.backup.address}}, 
is 
{{localhost:50100}}

while in the docs (hdfs-default.xml), it is 
{{0.0.0.0:50100}}

We should make the values consistent, as {{localhost}} has very different 
meanings from {{0.0.0.0}}. Since all the server daemons (e.g., 
{{dfs.namenode.backup.http-address}}, {{dfs.datanode.address}}) bind to 
{{0.0.0.0}}. I guess {{dfs.namenode.backup.address}} should also be 
{{0.0.0.0}}, unless there are some protection concerns (in this case we can 
change hdfs-default.xml).

*Patch (DFSConfigKeys.java)*
{code}
--- DFSConfigKeys.java  2015-12-19 10:39:38.982212865 -0800
+++ DFSConfigKeys.java  2015-12-19 10:40:10.830213622 -0800
@@ -132,7 +132,7 @@
   public static final String  DFS_DATANODE_RESTART_REPLICA_EXPIRY_KEY = 
"dfs.datanode.restart.replica.expiration";
   public static final long    DFS_DATANODE_RESTART_REPLICA_EXPIRY_DEFAULT = 50;
   public static final String  DFS_NAMENODE_BACKUP_ADDRESS_KEY = 
"dfs.namenode.backup.address";
-  public static final String  DFS_NAMENODE_BACKUP_ADDRESS_DEFAULT = 
"localhost:50100";
+  public static final String  DFS_NAMENODE_BACKUP_ADDRESS_DEFAULT = 
"0.0.0.0:50100";
   public static final String  DFS_NAMENODE_BACKUP_HTTP_ADDRESS_KEY = 
"dfs.namenode.backup.http-address";
   public static final String  DFS_NAMENODE_BACKUP_HTTP_ADDRESS_DEFAULT = 
"0.0.0.0:50105";
   public static final String  DFS_NAMENODE_BACKUP_SERVICE_RPC_ADDRESS_KEY = 
"dfs.namenode.backup.dnrpc-address";

{code}


> The default value of BackupNode should be "0.0.0.0" instead of "localhost"
> --------------------------------------------------------------------------
>
>                 Key: HDFS-9581
>                 URL: https://issues.apache.org/jira/browse/HDFS-9581
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: namenode
>    Affects Versions: 2.7.1, 2.6.3
>            Reporter: Tianyin Xu
>
> The current default value of config 
> parameter,{{dfs.namenode.backup.address}}, is 
> {{localhost:50100}}
> while in 
> [hdfs-default.xml|https://hadoop.apache.org/docs/r2.6.2/hadoop-project-dist/hadoop-hdfs/hdfs-default.xml],
>  it is 
> {{0.0.0.0:50100}}
> We should make the values consistent, as {{localhost}} has very different 
> meanings from {{0.0.0.0}}. Since all the server daemons (e.g., 
> {{dfs.namenode.backup.http-address}}, {{dfs.datanode.address}}) bind to 
> {{0.0.0.0}}. I guess {{dfs.namenode.backup.address}} should also be 
> {{0.0.0.0}}, unless there are some protection concerns (in this case we can 
> change hdfs-default.xml).
> *Patch (DFSConfigKeys.java)*
> {code}
> --- DFSConfigKeys.java        2015-12-19 10:39:38.982212865 -0800
> +++ DFSConfigKeys.java        2015-12-19 10:40:10.830213622 -0800
> @@ -132,7 +132,7 @@
>    public static final String  DFS_DATANODE_RESTART_REPLICA_EXPIRY_KEY = 
> "dfs.datanode.restart.replica.expiration";
>    public static final long    DFS_DATANODE_RESTART_REPLICA_EXPIRY_DEFAULT = 
> 50;
>    public static final String  DFS_NAMENODE_BACKUP_ADDRESS_KEY = 
> "dfs.namenode.backup.address";
> -  public static final String  DFS_NAMENODE_BACKUP_ADDRESS_DEFAULT = 
> "localhost:50100";
> +  public static final String  DFS_NAMENODE_BACKUP_ADDRESS_DEFAULT = 
> "0.0.0.0:50100";
>    public static final String  DFS_NAMENODE_BACKUP_HTTP_ADDRESS_KEY = 
> "dfs.namenode.backup.http-address";
>    public static final String  DFS_NAMENODE_BACKUP_HTTP_ADDRESS_DEFAULT = 
> "0.0.0.0:50105";
>    public static final String  DFS_NAMENODE_BACKUP_SERVICE_RPC_ADDRESS_KEY = 
> "dfs.namenode.backup.dnrpc-address";
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to