[
https://issues.apache.org/jira/browse/HDDS-1958?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li reassigned HDDS-1958:
--
Assignee: Xiang Li
> Container time information returned by "scmcli list" is not human friendly
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Status: Patch Available (was: Open)
> Avoid NPE when SectionName#fromString() returns null
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16763210#comment-16763210
]
Xiang Li commented on HDFS-14172:
-
Thanks [~linyiqun] for the comments!
bq. Can we reuse sectionName to
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Status: Open (was: Patch Available)
> Avoid NPE when SectionName#fromString() returns null
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Attachment: HADOOP-14172.006.patch
> Avoid NPE when SectionName#fromString() returns null
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Status: Patch Available (was: Open)
> Avoid NPE when SectionName#fromString() returns null
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Attachment: HADOOP-14172.005.patch
> Avoid NPE when SectionName#fromString() returns null
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Status: Open (was: Patch Available)
> Avoid NPE when SectionName#fromString() returns null
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762700#comment-16762700
]
Xiang Li commented on HDFS-14172:
-
[~adam.antal] Thanks for the comments! Corrected and patch v005 is
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Status: Open (was: Patch Available)
> Avoid NPE when SectionName#fromString() returns null
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Status: Patch Available (was: Open)
> Avoid NPE when SectionName#fromString() returns null
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Attachment: HADOOP-14172.004.patch
> Avoid NPE when SectionName#fromString() returns null
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16762398#comment-16762398
]
Xiang Li commented on HDFS-14172:
-
[~adam.antal] Would you please check patch 004 ? I removed the "else"
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759264#comment-16759264
]
Xiang Li commented on HDFS-14172:
-
[~linyiqun] [~adam.antal], could you please review the patch v003 when
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759262#comment-16759262
]
Xiang Li commented on HDFS-14172:
-
The UT errors reported are not related. Could get them passed on my
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Description:
In FSImageFormatProtobuf.SectionName#fromString(), as follows:
{code:java}
public static
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Attachment: HADOOP-14172.003.patch
> Avoid NPE when SectionName#fromString() returns null
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Status: Patch Available (was: Open)
> Avoid NPE when SectionName#fromString() returns null
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757247#comment-16757247
]
Xiang Li commented on HDFS-14172:
-
[~linyiqun] Patch v003 is uploaded to
* Throw an IOException instead
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Status: Open (was: Patch Available)
> Avoid NPE when SectionName#fromString() returns null
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757067#comment-16757067
]
Xiang Li commented on HDFS-14172:
-
[~linyiqun]
bq. can we revert additional change and make this JIRA
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757034#comment-16757034
]
Xiang Li edited comment on HDFS-14172 at 1/31/19 9:10 AM:
--
Hi [~linyiqun],
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Summary: Avoid NPE when SectionName#fromString() returns null (was: Handle
NPE when
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Status: Patch Available (was: Open)
> Handle NPE when SectionName#fromString() returns null
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Attachment: HADOOP-14172.002.patch
> Handle NPE when SectionName#fromString() returns null
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757034#comment-16757034
]
Xiang Li edited comment on HDFS-14172 at 1/31/19 9:11 AM:
--
Hi [~linyiqun],
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757034#comment-16757034
]
Xiang Li edited comment on HDFS-14172 at 1/31/19 9:11 AM:
--
Hi [~linyiqun],
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Status: Open (was: Patch Available)
> Handle NPE when SectionName#fromString() returns null
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Summary: Handle NPE when SectionName#fromString() returns null (was:
Return a default SectionName to
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16757034#comment-16757034
]
Xiang Li commented on HDFS-14172:
-
Hi [~linyiqun], [~adam.antal], thanks for your comments!
Regarding the
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755122#comment-16755122
]
Xiang Li commented on HDFS-14172:
-
[~linyiqun] Really appreciate it if you could help to take a look at
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16755094#comment-16755094
]
Xiang Li commented on HDFS-14172:
-
Upload patch 001 to add a UT for this change. [~xyao] Could you
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Status: Patch Available (was: Open)
> Return a default SectionName to avoid NPE
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Attachment: HADOOP-14172.001.patch
> Return a default SectionName to avoid NPE
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Status: Open (was: Patch Available)
> Return a default SectionName to avoid NPE
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16752275#comment-16752275
]
Xiang Li commented on HDFS-14172:
-
The UT failures reported are not due to the patch. Tested those on my
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16751190#comment-16751190
]
Xiang Li commented on HDFS-14172:
-
Attached the very first patch (v000) to demonstrate my idea. Working
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Status: Patch Available (was: Open)
> Return a default SectionName to avoid NPE
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Attachment: HADOOP-14172.000.patch
> Return a default SectionName to avoid NPE
>
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747635#comment-16747635
]
Xiang Li edited comment on HDFS-14172 at 1/21/19 5:01 AM:
--
[~adam.antal]
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16747635#comment-16747635
]
Xiang Li commented on HDFS-14172:
-
[~adam.antal] [~dhruba] Could you please review if those make any
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745877#comment-16745877
]
Xiang Li edited comment on HDFS-14172 at 1/18/19 8:58 AM:
--
[~adam.antal], thanks
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16745877#comment-16745877
]
Xiang Li commented on HDFS-14172:
-
[~adam.antal], thanks very much for the comments!
1. I found there is
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Description:
In FSImageFormatProtobuf.SectionName#fromString(), as follows:
{code:java}
public static
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728581#comment-16728581
]
Xiang Li edited comment on HDFS-14172 at 12/25/18 3:44 AM:
---
We met the NPE
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728581#comment-16728581
]
Xiang Li commented on HDFS-14172:
-
We met the NPE under the scenario that: we applied the patch of
[
https://issues.apache.org/jira/browse/HDFS-14172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-14172:
Description:
In FSImageFormatProtobuf.SectionName#fromString(), as follows:
{code:java}
public static
Xiang Li created HDFS-14172:
---
Summary: Return a default SectionName to avoid NPE
Key: HDFS-14172
URL: https://issues.apache.org/jira/browse/HDFS-14172
Project: Hadoop HDFS
Issue Type: Improvement
[
https://issues.apache.org/jira/browse/HDFS-8738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16723678#comment-16723678
]
Xiang Li commented on HDFS-8738:
Agree with Arpit. Add the link as a dup of HDFS-9572.
> Limit Exceptions
[
https://issues.apache.org/jira/browse/HDFS-7197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16679267#comment-16679267
]
Xiang Li commented on HDFS-7197:
[~benoyantony], I am not sure if HDFS-9034 could be added as a sub-task
[
https://issues.apache.org/jira/browse/HDFS-13982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644506#comment-16644506
]
Xiang Li commented on HDFS-13982:
-
Trying to use some functions of enum to rewrite the switch/case logic.
[
https://issues.apache.org/jira/browse/HDFS-13982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-13982:
Description:
In PBHelperClient, there are 2 functions to convert between StorageTypeProto
and
[
https://issues.apache.org/jira/browse/HDFS-13982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Xiang Li updated HDFS-13982:
Description:
In PBHelperClient, there are 2 functions to convert between StorageTypeProto
and
Xiang Li created HDFS-13982:
---
Summary: convertStorageType() in PBHelperClient is not easy to
extend when adding new storage types
Key: HDFS-13982
URL: https://issues.apache.org/jira/browse/HDFS-13982
[
https://issues.apache.org/jira/browse/HDFS-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16644499#comment-16644499
]
Xiang Li commented on HDFS-7076:
Hi all, if you are about to use the patch, please be aware that Mover
[
https://issues.apache.org/jira/browse/HDFS-7076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16524706#comment-16524706
]
Xiang Li commented on HDFS-7076:
[~jingzhao] Could you please share some updates for this JIRA if there
[
https://issues.apache.org/jira/browse/HDFS-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16288578#comment-16288578
]
Xiang Li commented on HDFS-10453:
-
Agree. Thanks xiaoqiao!
> ReplicationMonitor thread could stuck for
[
https://issues.apache.org/jira/browse/HDFS-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16287059#comment-16287059
]
Xiang Li commented on HDFS-10453:
-
[~hexiaoqiao], thanks for the patch and quick update!
Shall we need to
[
https://issues.apache.org/jira/browse/HDFS-10453?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16281396#comment-16281396
]
Xiang Li commented on HDFS-10453:
-
Hi [~hexiaoqiao], we met the same issue and thanks for the patch!
I
59 matches
Mail list logo
