[jira] [Commented] (HDFS-6832) Fix the usage of 'hdfs namenode' command
[
https://issues.apache.org/jira/browse/HDFS-6832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14151273#comment-14151273
]
skrho commented on HDFS-6832:
-
to~ Suresh Srinivas
Can you give me chance to contribute source to greate Hadoop? ^^
Fix the usage of 'hdfs namenode' command
Key: HDFS-6832
URL: https://issues.apache.org/jira/browse/HDFS-6832
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 2.4.1
Reporter: Akira AJISAKA
Assignee: skrho
Priority: Minor
Labels: newbie
Attachments: hdfs-6832.txt, hdfs-6832_001.txt, hdfs-6832_002.txt
{code}
[root@trunk ~]# hdfs namenode -help
Usage: java NameNode [-backup] |
[-checkpoint] |
[-format [-clusterid cid ] [-force] [-nonInteractive] ] |
[-upgrade [-clusterid cid] [-renameReservedk-v pairs] ] |
[-upgradeOnly [-clusterid cid] [-renameReservedk-v pairs] ] |
[-rollback] |
[-rollingUpgrade downgrade|rollback ] |
[-finalize] |
[-importCheckpoint] |
[-initializeSharedEdits] |
[-bootstrapStandby] |
[-recover [ -force] ] |
[-metadataVersion ] ]
{code}
There're some issues in the usage to be fixed.
# Usage: java NameNode should be Usage: hdfs namenode
# -rollingUpgrade started option should be added
# The last ']' should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Assigned] (HDFS-7101) Potential null dereference in DFSck#doWork()
[
https://issues.apache.org/jira/browse/HDFS-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
skrho reassigned HDFS-7101:
---
Assignee: skrho
Potential null dereference in DFSck#doWork()
Key: HDFS-7101
URL: https://issues.apache.org/jira/browse/HDFS-7101
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Ted Yu
Assignee: skrho
Priority: Minor
{code}
String lastLine = null;
int errCode = -1;
try {
while ((line = input.readLine()) != null) {
...
if (lastLine.endsWith(NamenodeFsck.HEALTHY_STATUS)) {
errCode = 0;
{code}
If readLine() throws exception, lastLine may be null, leading to NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-7101) Potential null dereference in DFSck#doWork()
[
https://issues.apache.org/jira/browse/HDFS-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14147608#comment-14147608
]
skrho commented on HDFS-7101:
-
I think.. default value is needed when while block exception is happended..
So.. I changed lastLine initial value from null to NamenodeFsck.CORRUPT_STATUS
How about that?
Potential null dereference in DFSck#doWork()
Key: HDFS-7101
URL: https://issues.apache.org/jira/browse/HDFS-7101
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Ted Yu
Assignee: skrho
Priority: Minor
Attachments: HDFS-7101_001.patch
{code}
String lastLine = null;
int errCode = -1;
try {
while ((line = input.readLine()) != null) {
...
if (lastLine.endsWith(NamenodeFsck.HEALTHY_STATUS)) {
errCode = 0;
{code}
If readLine() throws exception, lastLine may be null, leading to NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-7101) Potential null dereference in DFSck#doWork()
[
https://issues.apache.org/jira/browse/HDFS-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
skrho updated HDFS-7101:
Attachment: HDFS-7101_001.patch
Potential null dereference in DFSck#doWork()
Key: HDFS-7101
URL: https://issues.apache.org/jira/browse/HDFS-7101
Project: Hadoop HDFS
Issue Type: Bug
Reporter: Ted Yu
Assignee: skrho
Priority: Minor
Attachments: HDFS-7101_001.patch
{code}
String lastLine = null;
int errCode = -1;
try {
while ((line = input.readLine()) != null) {
...
if (lastLine.endsWith(NamenodeFsck.HEALTHY_STATUS)) {
errCode = 0;
{code}
If readLine() throws exception, lastLine may be null, leading to NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-7101) Potential null dereference in DFSck#doWork()
[
https://issues.apache.org/jira/browse/HDFS-7101?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
skrho updated HDFS-7101:
Affects Version/s: 2.5.1
Status: Patch Available (was: Open)
Potential null dereference in DFSck#doWork()
Key: HDFS-7101
URL: https://issues.apache.org/jira/browse/HDFS-7101
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 2.5.1
Reporter: Ted Yu
Assignee: skrho
Priority: Minor
Attachments: HDFS-7101_001.patch
{code}
String lastLine = null;
int errCode = -1;
try {
while ((line = input.readLine()) != null) {
...
if (lastLine.endsWith(NamenodeFsck.HEALTHY_STATUS)) {
errCode = 0;
{code}
If readLine() throws exception, lastLine may be null, leading to NPE.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-6832) Fix the usage of 'hdfs namenode' command
[
https://issues.apache.org/jira/browse/HDFS-6832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
skrho updated HDFS-6832:
Attachment: hdfs-6832_002.txt
Here new patch~ Please review my source ~~
Fix the usage of 'hdfs namenode' command
Key: HDFS-6832
URL: https://issues.apache.org/jira/browse/HDFS-6832
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 2.4.1
Reporter: Akira AJISAKA
Assignee: skrho
Priority: Minor
Labels: newbie
Attachments: hdfs-6832.txt, hdfs-6832_001.txt, hdfs-6832_002.txt
{code}
[root@trunk ~]# hdfs namenode -help
Usage: java NameNode [-backup] |
[-checkpoint] |
[-format [-clusterid cid ] [-force] [-nonInteractive] ] |
[-upgrade [-clusterid cid] [-renameReservedk-v pairs] ] |
[-upgradeOnly [-clusterid cid] [-renameReservedk-v pairs] ] |
[-rollback] |
[-rollingUpgrade downgrade|rollback ] |
[-finalize] |
[-importCheckpoint] |
[-initializeSharedEdits] |
[-bootstrapStandby] |
[-recover [ -force] ] |
[-metadataVersion ] ]
{code}
There're some issues in the usage to be fixed.
# Usage: java NameNode should be Usage: hdfs namenode
# -rollingUpgrade started option should be added
# The last ']' should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (HDFS-6832) Fix the usage of 'hdfs namenode' command
[
https://issues.apache.org/jira/browse/HDFS-6832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14117031#comment-14117031
]
skrho commented on HDFS-6832:
-
New patch name is hdfs-6832_002.txt
Fix the usage of 'hdfs namenode' command
Key: HDFS-6832
URL: https://issues.apache.org/jira/browse/HDFS-6832
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 2.4.1
Reporter: Akira AJISAKA
Assignee: skrho
Priority: Minor
Labels: newbie
Attachments: hdfs-6832.txt, hdfs-6832_001.txt, hdfs-6832_002.txt
{code}
[root@trunk ~]# hdfs namenode -help
Usage: java NameNode [-backup] |
[-checkpoint] |
[-format [-clusterid cid ] [-force] [-nonInteractive] ] |
[-upgrade [-clusterid cid] [-renameReservedk-v pairs] ] |
[-upgradeOnly [-clusterid cid] [-renameReservedk-v pairs] ] |
[-rollback] |
[-rollingUpgrade downgrade|rollback ] |
[-finalize] |
[-importCheckpoint] |
[-initializeSharedEdits] |
[-bootstrapStandby] |
[-recover [ -force] ] |
[-metadataVersion ] ]
{code}
There're some issues in the usage to be fixed.
# Usage: java NameNode should be Usage: hdfs namenode
# -rollingUpgrade started option should be added
# The last ']' should be removed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (HDFS-6832) Fix the usage of 'hdfs namenode' command
[
https://issues.apache.org/jira/browse/HDFS-6832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
skrho updated HDFS-6832:
Attachment: hdfs-6832.txt
Please reivew my patch and give me chance to contribute
Fix the usage of 'hdfs namenode' command
Key: HDFS-6832
URL: https://issues.apache.org/jira/browse/HDFS-6832
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 2.4.1
Reporter: Akira AJISAKA
Priority: Minor
Labels: newbie
Attachments: hdfs-6832.txt
{code}
[root@trunk ~]# hdfs namenode -help
Usage: java NameNode [-backup] |
[-checkpoint] |
[-format [-clusterid cid ] [-force] [-nonInteractive] ] |
[-upgrade [-clusterid cid] [-renameReservedk-v pairs] ] |
[-upgradeOnly [-clusterid cid] [-renameReservedk-v pairs] ] |
[-rollback] |
[-rollingUpgrade downgrade|rollback ] |
[-finalize] |
[-importCheckpoint] |
[-initializeSharedEdits] |
[-bootstrapStandby] |
[-recover [ -force] ] |
[-metadataVersion ] ]
{code}
There're some issues in the usage to be fixed.
# Usage: java NameNode should be Usage: hdfs namenode
# -rollingUpgrade started option should be added
# The last ']' should be removed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HDFS-6832) Fix the usage of 'hdfs namenode' command
[
https://issues.apache.org/jira/browse/HDFS-6832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
skrho updated HDFS-6832:
Target Version/s: 2.5.0
Status: Patch Available (was: Open)
Please review my patch and give me chance to contribute source
Fix the usage of 'hdfs namenode' command
Key: HDFS-6832
URL: https://issues.apache.org/jira/browse/HDFS-6832
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 2.4.1
Reporter: Akira AJISAKA
Priority: Minor
Labels: newbie
Attachments: hdfs-6832.txt
{code}
[root@trunk ~]# hdfs namenode -help
Usage: java NameNode [-backup] |
[-checkpoint] |
[-format [-clusterid cid ] [-force] [-nonInteractive] ] |
[-upgrade [-clusterid cid] [-renameReservedk-v pairs] ] |
[-upgradeOnly [-clusterid cid] [-renameReservedk-v pairs] ] |
[-rollback] |
[-rollingUpgrade downgrade|rollback ] |
[-finalize] |
[-importCheckpoint] |
[-initializeSharedEdits] |
[-bootstrapStandby] |
[-recover [ -force] ] |
[-metadataVersion ] ]
{code}
There're some issues in the usage to be fixed.
# Usage: java NameNode should be Usage: hdfs namenode
# -rollingUpgrade started option should be added
# The last ']' should be removed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
[jira] [Updated] (HDFS-6832) Fix the usage of 'hdfs namenode' command
[
https://issues.apache.org/jira/browse/HDFS-6832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
skrho updated HDFS-6832:
Attachment: hdfs-6832_001.txt
Hello~~ I made trunk patch~~ ( hdfs-6832_001.txt )
Thank you..
Fix the usage of 'hdfs namenode' command
Key: HDFS-6832
URL: https://issues.apache.org/jira/browse/HDFS-6832
Project: Hadoop HDFS
Issue Type: Bug
Affects Versions: 2.4.1
Reporter: Akira AJISAKA
Assignee: skrho
Priority: Minor
Labels: newbie
Attachments: hdfs-6832.txt, hdfs-6832_001.txt
{code}
[root@trunk ~]# hdfs namenode -help
Usage: java NameNode [-backup] |
[-checkpoint] |
[-format [-clusterid cid ] [-force] [-nonInteractive] ] |
[-upgrade [-clusterid cid] [-renameReservedk-v pairs] ] |
[-upgradeOnly [-clusterid cid] [-renameReservedk-v pairs] ] |
[-rollback] |
[-rollingUpgrade downgrade|rollback ] |
[-finalize] |
[-importCheckpoint] |
[-initializeSharedEdits] |
[-bootstrapStandby] |
[-recover [ -force] ] |
[-metadataVersion ] ]
{code}
There're some issues in the usage to be fixed.
# Usage: java NameNode should be Usage: hdfs namenode
# -rollingUpgrade started option should be added
# The last ']' should be removed.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
