[jira] [Commented] (HDFS-11005) Ozone: TestBlockPoolManager fails in ozone branch.
[ https://issues.apache.org/jira/browse/HDFS-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16450536#comment-16450536 ] Hudson commented on HDFS-11005: --- SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14057 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14057/]) HDFS-11005. Ozone: TestBlockPoolManager fails in ozone branch. (aengineer: rev eb8f2b2ca0835d756132e56c854685c9c4fa4eab) * (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BlockPoolManager.java > Ozone: TestBlockPoolManager fails in ozone branch. > -- > > Key: HDFS-11005 > URL: https://issues.apache.org/jira/browse/HDFS-11005 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Anu Engineer >Assignee: Chen Liang >Priority: Major > Attachments: HDFS-11005-HDFS-7240.001.patch, > HDFS-11005-HDFS-7240.002.patch > > > TestBlockPoolManager.testFederationRefresh fails in the ozone branch with > the following error message. > {noformat} > Running org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager > Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.231 sec <<< > FAILURE! - in org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager > testFederationRefresh(org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager) > Time elapsed: 0.043 sec <<< FAILURE! > org.junit.ComparisonFailure: expected: refresh #2] > > but was: refresh #1] > > > at org.junit.Assert.assertEquals(Assert.java:115) > at org.junit.Assert.assertEquals(Assert.java:144) > at > org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager.testFederationRefresh(TestBlockPoolManager.java:123) > Results : > Failed tests: > TestBlockPoolManager.testFederationRefresh:123 expected: refresh #2] > > but was: refresh #1] > > > {noformat} -- This message was sent by Atlassian JIRA (v7.6.3#76005) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11005) Ozone: TestBlockPoolManager fails in ozone branch.
[ https://issues.apache.org/jira/browse/HDFS-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606955#comment-15606955 ] Xiaoyu Yao commented on HDFS-11005: --- Thanks [~arpitagarwal]/[~vagarychen] for the discussion, +1 for fix this one with v1 patch. > Ozone: TestBlockPoolManager fails in ozone branch. > -- > > Key: HDFS-11005 > URL: https://issues.apache.org/jira/browse/HDFS-11005 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Anu Engineer >Assignee: Chen Liang > Attachments: HDFS-11005-HDFS-7240.001.patch, > HDFS-11005-HDFS-7240.002.patch > > > TestBlockPoolManager.testFederationRefresh fails in the ozone branch with > the following error message. > {noformat} > Running org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager > Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.231 sec <<< > FAILURE! - in org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager > testFederationRefresh(org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager) > Time elapsed: 0.043 sec <<< FAILURE! > org.junit.ComparisonFailure: expected: refresh #2] > > but was: refresh #1] > > > at org.junit.Assert.assertEquals(Assert.java:115) > at org.junit.Assert.assertEquals(Assert.java:144) > at > org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager.testFederationRefresh(TestBlockPoolManager.java:123) > Results : > Failed tests: > TestBlockPoolManager.testFederationRefresh:123 expected: refresh #2] > > but was: refresh #1] > > > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11005) Ozone: TestBlockPoolManager fails in ozone branch.
[ https://issues.apache.org/jira/browse/HDFS-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606892#comment-15606892 ] Arpit Agarwal commented on HDFS-11005: -- [~vagarychen] just pointed out offline that using the immutable Collections.emptyMap would not work here. The v1 patch looks like the simplest correct fix. There are two extra map allocations but refreshing the list of namenodes will be a very rare operation. [~xyao] are you okay with the v1 patch? > Ozone: TestBlockPoolManager fails in ozone branch. > -- > > Key: HDFS-11005 > URL: https://issues.apache.org/jira/browse/HDFS-11005 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Anu Engineer >Assignee: Chen Liang > Attachments: HDFS-11005-HDFS-7240.001.patch, > HDFS-11005-HDFS-7240.002.patch > > > TestBlockPoolManager.testFederationRefresh fails in the ozone branch with > the following error message. > {noformat} > Running org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager > Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.231 sec <<< > FAILURE! - in org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager > testFederationRefresh(org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager) > Time elapsed: 0.043 sec <<< FAILURE! > org.junit.ComparisonFailure: expected: refresh #2] > > but was: refresh #1] > > > at org.junit.Assert.assertEquals(Assert.java:115) > at org.junit.Assert.assertEquals(Assert.java:144) > at > org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager.testFederationRefresh(TestBlockPoolManager.java:123) > Results : > Failed tests: > TestBlockPoolManager.testFederationRefresh:123 expected: refresh #2] > > but was: refresh #1] > > > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11005) Ozone: TestBlockPoolManager fails in ozone branch.
[ https://issues.apache.org/jira/browse/HDFS-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15606788#comment-15606788 ] Arpit Agarwal commented on HDFS-11005: -- Hi [~vagarychen], thanks for the fix. In the v2 patch - we should not overwrite newAddressMap in the exception handler. In case getNNLifelineRpcAddressesForCluster throws we will ignore the result returned by getNNServiceRpcAddressesForCluster which is incorrect. The v1 patch lgtm. One improvement that addresses Xiaoyu's feedback is to use {{Collections.emptyMap()}} instead of allocating empty maps. i.e. {code} Map> newAddressMap = Collections.emptyMap(); Map > newLifelineAddressMap = Collections.emptyMap(); {code} > Ozone: TestBlockPoolManager fails in ozone branch. > -- > > Key: HDFS-11005 > URL: https://issues.apache.org/jira/browse/HDFS-11005 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Anu Engineer >Assignee: Chen Liang > Attachments: HDFS-11005-HDFS-7240.001.patch, > HDFS-11005-HDFS-7240.002.patch > > > TestBlockPoolManager.testFederationRefresh fails in the ozone branch with > the following error message. > {noformat} > Running org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager > Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.231 sec <<< > FAILURE! - in org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager > testFederationRefresh(org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager) > Time elapsed: 0.043 sec <<< FAILURE! > org.junit.ComparisonFailure: expected: refresh #2] > > but was: refresh #1] > > > at org.junit.Assert.assertEquals(Assert.java:115) > at org.junit.Assert.assertEquals(Assert.java:144) > at > org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager.testFederationRefresh(TestBlockPoolManager.java:123) > Results : > Failed tests: > TestBlockPoolManager.testFederationRefresh:123 expected: refresh #2] > > but was: refresh #1] > > > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11005) Ozone: TestBlockPoolManager fails in ozone branch.
[ https://issues.apache.org/jira/browse/HDFS-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593514#comment-15593514 ] Arpit Agarwal commented on HDFS-11005: -- Thanks for the heads up [~vagarychen]. I will also review this patch tomorrow. > Ozone: TestBlockPoolManager fails in ozone branch. > -- > > Key: HDFS-11005 > URL: https://issues.apache.org/jira/browse/HDFS-11005 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Anu Engineer >Assignee: Chen Liang > Attachments: HDFS-11005-HDFS-7240.001.patch, > HDFS-11005-HDFS-7240.002.patch > > > TestBlockPoolManager.testFederationRefresh fails in the ozone branch with > the following error message. > {noformat} > Running org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager > Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.231 sec <<< > FAILURE! - in org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager > testFederationRefresh(org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager) > Time elapsed: 0.043 sec <<< FAILURE! > org.junit.ComparisonFailure: expected: refresh #2] > > but was: refresh #1] > > > at org.junit.Assert.assertEquals(Assert.java:115) > at org.junit.Assert.assertEquals(Assert.java:144) > at > org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager.testFederationRefresh(TestBlockPoolManager.java:123) > Results : > Failed tests: > TestBlockPoolManager.testFederationRefresh:123 expected: refresh #2] > > but was: refresh #1] > > > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11005) Ozone: TestBlockPoolManager fails in ozone branch.
[ https://issues.apache.org/jira/browse/HDFS-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593413#comment-15593413 ] Hadoop QA commented on HDFS-11005: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 18s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 23s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 45s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 28s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 54s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 12s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 49s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 40s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 48s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 43s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 9s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 38s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 58m 35s{color} | {color:green} hadoop-hdfs in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 20s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 77m 55s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Issue | HDFS-11005 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12834560/HDFS-11005-HDFS-7240.002.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux a1552164aace 3.13.0-95-generic #142-Ubuntu SMP Fri Aug 12 17:00:09 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | HDFS-7240 / c70775a | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/17241/testReport/ | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/17241/console | | Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Ozone: TestBlockPoolManager fails in ozone branch. > -- > > Key: HDFS-11005 > URL: https://issues.apache.org/jira/browse/HDFS-11005 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Anu Engineer >Assignee: Chen Liang > Attachments: HDFS-11005-HDFS-7240.001.patch, >
[jira] [Commented] (HDFS-11005) Ozone: TestBlockPoolManager fails in ozone branch.
[ https://issues.apache.org/jira/browse/HDFS-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593258#comment-15593258 ] Hadoop QA commented on HDFS-11005: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 0m 15s{color} | {color:blue} Docker mode activated. {color} | | {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} | | {color:red}-1{color} | {color:red} test4tests {color} | {color:red} 0m 0s{color} | {color:red} The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 12m 37s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 49s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 30s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 1m 0s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 18s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 2m 2s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 45s{color} | {color:green} HDFS-7240 passed {color} | | {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 50s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 46s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvnsite {color} | {color:green} 0m 49s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} mvneclipse {color} | {color:green} 0m 11s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} whitespace {color} | {color:green} 0m 0s{color} | {color:green} The patch has no whitespace issues. {color} | | {color:green}+1{color} | {color:green} findbugs {color} | {color:green} 1m 53s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 39s{color} | {color:green} the patch passed {color} | | {color:green}+1{color} | {color:green} unit {color} | {color:green} 59m 20s{color} | {color:green} hadoop-hdfs in the patch passed. {color} | | {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 20s{color} | {color:green} The patch does not generate ASF License warnings. {color} | | {color:black}{color} | {color:black} {color} | {color:black} 84m 49s{color} | {color:black} {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Image:yetus/hadoop:9560f25 | | JIRA Issue | HDFS-11005 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12834549/HDFS-11005-HDFS-7240.001.patch | | Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle | | uname | Linux 76cc859d527d 3.13.0-93-generic #140-Ubuntu SMP Mon Jul 18 21:21:05 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh | | git revision | HDFS-7240 / c70775a | | Default Java | 1.8.0_101 | | findbugs | v3.0.0 | | Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/17239/testReport/ | | modules | C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs | | Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/17239/console | | Powered by | Apache Yetus 0.4.0-SNAPSHOT http://yetus.apache.org | This message was automatically generated. > Ozone: TestBlockPoolManager fails in ozone branch. > -- > > Key: HDFS-11005 > URL: https://issues.apache.org/jira/browse/HDFS-11005 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Anu Engineer >Assignee: Chen Liang > Attachments: HDFS-11005-HDFS-7240.001.patch, >
[jira] [Commented] (HDFS-11005) Ozone: TestBlockPoolManager fails in ozone branch.
[ https://issues.apache.org/jira/browse/HDFS-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15593068#comment-15593068 ] Chen Liang commented on HDFS-11005: --- [~arpitagarwal] do you mind taking a look at the patch? as the {{putAll}} call was introduced in HDFS-10363, thanks! > Ozone: TestBlockPoolManager fails in ozone branch. > -- > > Key: HDFS-11005 > URL: https://issues.apache.org/jira/browse/HDFS-11005 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Anu Engineer >Assignee: Chen Liang > Attachments: HDFS-11005-HDFS-7240.001.patch > > > TestBlockPoolManager.testFederationRefresh fails in the ozone branch with > the following error message. > {noformat} > Running org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager > Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.231 sec <<< > FAILURE! - in org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager > testFederationRefresh(org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager) > Time elapsed: 0.043 sec <<< FAILURE! > org.junit.ComparisonFailure: expected: refresh #2] > > but was: refresh #1] > > > at org.junit.Assert.assertEquals(Assert.java:115) > at org.junit.Assert.assertEquals(Assert.java:144) > at > org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager.testFederationRefresh(TestBlockPoolManager.java:123) > Results : > Failed tests: > TestBlockPoolManager.testFederationRefresh:123 expected: refresh #2] > > but was: refresh #1] > > > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
[jira] [Commented] (HDFS-11005) Ozone: TestBlockPoolManager fails in ozone branch.
[ https://issues.apache.org/jira/browse/HDFS-11005?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15576805#comment-15576805 ] Chen Liang commented on HDFS-11005: --- I did some investigation, I haven't found the root cause but it looks like problem is that in {{testFederationRefresh}} ns1 and ns2 got flipped somehow. This being said, if changing {{conf.set(DFSConfigKeys.DFS_NAMESERVICES, "ns2");}} to {{conf.set(DFSConfigKeys.DFS_NAMESERVICES, "ns1");}} the test will pass. However in fact, it should be indeed "ns2" here, see HDFS-4669. I compared the log output of this test in this branch and trunk, and saw below: in this branch, I got: {{INFO datanode.DataNode (BlockPoolManager.java:doRefreshNamenodes(248)) - Stopping BPOfferServices for nameservices: ns1}} {{INFO datanode.TestBlockPoolManager (TestBlockPoolManager.java:doLog(94)) - stop #2}} {{INFO datanode.DataNode (BlockPoolManager.java:remove(103)) - Removed Mock BPOS #2}} {{INFO datanode.DataNode (BlockPoolManager.java:doRefreshNamenodes(261)) - Refreshing list of NNs for nameservices: ns2}} {{INFO datanode.TestBlockPoolManager (TestBlockPoolManager.java:doLog(94)) - refresh #1}} note that BlockPoolManager tries to stop ns1 and refresh ns2 but somehow it got changed to stop ns2 and refresh ns1 In trunk, I got: {{INFO datanode.DataNode (BlockPoolManager.java:doRefreshNamenodes(226)) - Stopping BPOfferServices for nameservices: ns1}} {{INFO datanode.TestBlockPoolManager (TestBlockPoolManager.java:doLog(92)) - stop #1}} {{INFO datanode.DataNode (BlockPoolManager.java:remove(102)) - Removed Mock BPOS #1}} {{INFO datanode.DataNode (BlockPoolManager.java:doRefreshNamenodes(239)) - Refreshing list of NNs for nameservices: ns2}} {{INFO datanode.TestBlockPoolManager (TestBlockPoolManager.java:doLog(92)) - refresh #2}} which is correct. > Ozone: TestBlockPoolManager fails in ozone branch. > -- > > Key: HDFS-11005 > URL: https://issues.apache.org/jira/browse/HDFS-11005 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: ozone >Affects Versions: HDFS-7240 >Reporter: Anu Engineer > > TestBlockPoolManager.testFederationRefresh fails in the ozone branch with > the following error message. > {noformat} > Running org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager > Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.231 sec <<< > FAILURE! - in org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager > testFederationRefresh(org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager) > Time elapsed: 0.043 sec <<< FAILURE! > org.junit.ComparisonFailure: expected: refresh #2] > > but was: refresh #1] > > > at org.junit.Assert.assertEquals(Assert.java:115) > at org.junit.Assert.assertEquals(Assert.java:144) > at > org.apache.hadoop.hdfs.server.datanode.TestBlockPoolManager.testFederationRefresh(TestBlockPoolManager.java:123) > Results : > Failed tests: > TestBlockPoolManager.testFederationRefresh:123 expected: refresh #2] > > but was: refresh #1] > > > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) - To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org