[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-12-18 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999809#comment-16999809 ] Xiaoqiao He commented on HDFS-14997: Some more information in our production cluster: we have

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-12-18 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16999460#comment-16999460 ] Wei-Chiu Chuang commented on HDFS-14997: Sorry forgot to mention I am +1 > BPServiceActor

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-12-11 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993275#comment-16993275 ] Xiaoqiao He commented on HDFS-14997: Thanks [~weichiu], {quote}Question: I can imagine DNA_INVALIDATE

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-12-10 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16993014#comment-16993014 ] Wei-Chiu Chuang commented on HDFS-14997: Sounds like an elegant solution. The commands received

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-12-10 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992773#comment-16992773 ] Íñigo Goiri commented on HDFS-14997: +1 on [^HDFS-14997.005.patch]. This is pretty core, so I'll give

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-12-09 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16992225#comment-16992225 ] Xiaoqiao He commented on HDFS-14997: Thanks [~elgoiri] for your comments. Actually I have deployed

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-12-05 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16989023#comment-16989023 ] Íñigo Goiri commented on HDFS-14997: What about making CommandProcessingThread a separate class? Just

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-12-03 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16987530#comment-16987530 ] Xiaoqiao He commented on HDFS-14997: Ping [~elgoiri],[~sodonnell],[~weichiu] any furthermore comments

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-27 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983557#comment-16983557 ] Xiaoqiao He commented on HDFS-14997: Check and rerun the failed unit tests at local, it could not be

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-27 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983431#comment-16983431 ] Hadoop QA commented on HDFS-14997: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-26 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16983253#comment-16983253 ] Xiaoqiao He commented on HDFS-14997: [~elgoiri] v005 try to fix checkstyle and run all failed unit

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-26 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982901#comment-16982901 ] Íñigo Goiri commented on HDFS-14997: In addition to the checkstyles we should use the logger format

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-26 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982829#comment-16982829 ] Hadoop QA commented on HDFS-14997: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-26 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16982686#comment-16982686 ] Xiaoqiao He commented on HDFS-14997: Thanks [~elgoiri] for your comments. v004 try to fix concerns

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-22 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980366#comment-16980366 ] Íñigo Goiri commented on HDFS-14997: Regarding the poll and take is just a matter of readability;

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-22 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980210#comment-16980210 ] Hadoop QA commented on HDFS-14997: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-22 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16980067#comment-16980067 ] Xiaoqiao He commented on HDFS-14997: Thanks [~elgoiri] for the deep reviews. {quote}Do we need to do

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-21 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979523#comment-16979523 ] Hadoop QA commented on HDFS-14997: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-21 Thread Jira
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979453#comment-16979453 ] Íñigo Goiri commented on HDFS-14997: We should add this to the metrics to be able to track if we are

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-21 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16979379#comment-16979379 ] Xiaoqiao He commented on HDFS-14997: [~sodonnell], Try to upload v002 patch and add unit test. Please

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-20 Thread Stephen O'Donnell (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978530#comment-16978530 ] Stephen O'Donnell commented on HDFS-14997: -- Yes, we often bump

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-20 Thread Xiaoqiao He (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978517#comment-16978517 ] Xiaoqiao He commented on HDFS-14997: Thanks [~sodonnell] for your comments. {quote}We have seen a lot

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-20 Thread Stephen O'Donnell (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978370#comment-16978370 ] Stephen O'Donnell commented on HDFS-14997: -- I think fixing this is a great idea. We have seen a

[jira] [Commented] (HDFS-14997) BPServiceActor process command from NameNode asynchronously

2019-11-20 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/HDFS-14997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16978187#comment-16978187 ] Hadoop QA commented on HDFS-14997: -- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||