[ 
https://issues.apache.org/jira/browse/HDFS-13148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16388630#comment-16388630
 ] 

Rushabh S Shah edited comment on HDFS-13148 at 3/6/18 10:26 PM:
----------------------------------------------------------------

Thanks [~hanishakoneru] for working on this.
I haven't gone through the whole patch but have one basic question.
 Can't {{TestEncryptionZonesWithKMSandFederation}} just extend 
{{TestEncryptionZonesWithKMS}} and override {{createCluster}}.
 {{TestEncryptionZones}} will have createCluster method with one namenode and 
{{TestEncryptionZonesWithKMSandFederation}} will override and create 
{{simpleFederatedTopology}}.
 Does it make sense ?
 That way we will have hierarchy. {{TestEncryptionZonesWithKMSandFederation}} 
--> {{TestEncryptionZonesWithKMS}} --> {{TestEncryptionZones}}


was (Author: shahrs87):
Thanks [~hanishakoneru] for working on this.
Can't {{TestEncryptionZonesWithKMSandFederation}} just extend 
{{TestEncryptionZonesWithKMS}} and override {{createCluster}}.
 {{TestEncryptionZones}} will have createCluster method with one namenode and 
{{TestEncryptionZonesWithKMSandFederation}} will override and create 
{{simpleFederatedTopology}}.
Does it make sense ?
That way we will have hierarchy.  {{TestEncryptionZonesWithKMSandFederation}} 
--> {{TestEncryptionZonesWithKMS}} --> {{TestEncryptionZones}}

> Unit test for EZ with KMS and Federation
> ----------------------------------------
>
>                 Key: HDFS-13148
>                 URL: https://issues.apache.org/jira/browse/HDFS-13148
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: test
>            Reporter: Hanisha Koneru
>            Assignee: Hanisha Koneru
>            Priority: Major
>         Attachments: HDFS-13148.001.patch, HDFS-13148.002.patch, 
> HDFS-13148.003.patch
>
>
> It would be good to have some unit tests for testing KMS and EZ on a 
> federated cluster. We can start with basic EZ operations. For example, create 
> EZs on two namespaces with different keys using one KMS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to