[ 
https://issues.apache.org/jira/browse/HDFS-14188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16767638#comment-16767638
 ] 

Shweta edited comment on HDFS-14188 at 2/13/19 10:15 PM:
---------------------------------------------------------

[~knanasi] thanks for the patch. Looks good to me. I would agree with 
[~ayushtkn] to have the tests merged into one since it's the same underlying 
command and configuration being tested with different use cases.
There are a few checkstyle warnings for whitespace and char length in a line. 

+1 (non-binding)


was (Author: shwetayakkali):
[~knanasi] thanks for the patch. Looks good to me. I would agree with 
[~ayushtkn] to have the tests merged into one since it's the same underlying 
command being tested with different use cases.
There are a few checkstyle warnings for whitespace and char length in a line. 

+1 (non-binding)

> Make hdfs ec -verifyClusterSetup command accept an erasure coding policy as a 
> parameter
> ---------------------------------------------------------------------------------------
>
>                 Key: HDFS-14188
>                 URL: https://issues.apache.org/jira/browse/HDFS-14188
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: erasure-coding
>    Affects Versions: 3.1.1
>            Reporter: Kitti Nanasi
>            Assignee: Kitti Nanasi
>            Priority: Major
>         Attachments: HDFS-14188.001.patch, HDFS-14188.002.patch, 
> HDFS-14188.003.patch
>
>
> hdfs ec -verifyClusterSetup command verifies if there are enough data nodes 
> and racks for the enabled erasure coding policies
> I think it would be beneficial if it could accept an erasure coding policy as 
> a parameter optionally. For example the following command would run the 
> verify for only the RS-6-3-1024k policy.
> {code:java}
> hdfs ec -verifyClusterSetup -policy RS-6-3-1024k
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to