[ 
https://issues.apache.org/jira/browse/HDFS-8766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14978819#comment-14978819
 ] 

Haohui Mai edited comment on HDFS-8766 at 10/28/15 5:27 PM:
------------------------------------------------------------

{code}
+#include "libhdfspp/hdfs.h"

+  auto callback = [stat, &fs](const Status &s, FileSystem *f) {
+    fs = f;
+    stat->set_value(s);
+  };
{code}

It might make sense to rename the {{libhdfspp/hdfs.h}} to 
{{libhdfspp/libhdfspp.h}}. It is also beneficial to change the way how the 
{{FileSystem}} works to only make the connection when calling {{Connect()}}.

However, I think both of them can be addressed in follow-up jiras.


was (Author: wheat9):
Things that be a
{code}
+#include "libhdfspp/hdfs.h"

+  auto callback = [stat, &fs](const Status &s, FileSystem *f) {
+    fs = f;
+    stat->set_value(s);
+  };
{code}

It might make sense to rename the {{libhdfspp/hdfs.h}} to 
{{libhdfspp/libhdfspp.h}}. It is also beneficial to change the way how the 
{{FileSystem}} works to only make the connection when calling {{Connect()}}. 
They can be addressed in follow-up jiras.

> Implement a libhdfs(3) compatible API
> -------------------------------------
>
>                 Key: HDFS-8766
>                 URL: https://issues.apache.org/jira/browse/HDFS-8766
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs-client
>            Reporter: James Clampffer
>            Assignee: James Clampffer
>         Attachments: HDFS-8766.HDFS-8707.000.patch, 
> HDFS-8766.HDFS-8707.001.patch, HDFS-8766.HDFS-8707.002.patch, 
> HDFS-8766.HDFS-8707.003.patch, HDFS-8766.HDFS-8707.004.patch, 
> HDFS-8766.HDFS-8707.005.patch, HDFS-8766.HDFS-8707.006.patch, 
> HDFS-8766.HDFS-8707.007.patch, HDFS-8766.HDFS-8707.008.patch, 
> HDFS-8766.HDFS-8707.009.patch, HDFS-8766.HDFS-8707.010.patch, 
> HDFS-8766.HDFS-8707.011.patch
>
>
> Add a synchronous API that is compatible with the hdfs.h header used in 
> libhdfs and libhdfs3.  This will make it possible for projects using 
> libhdfs/libhdfs3 to relink against libhdfspp with minimal changes.
> This also provides a pure C interface that can be linked against projects 
> that aren't built in C++11 mode for various reasons but use the same 
> compiler.  It also allows many other programming languages to access 
> libhdfspp through builtin FFI interfaces.
> The libhdfs API is very similar to the posix file API which makes it easier 
> for programs built using posix filesystem calls to be modified to access HDFS.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to