[ 
https://issues.apache.org/jira/browse/HDDS-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16953672#comment-16953672
 ] 

Li Cheng commented on HDDS-1570:
--------------------------------

As I look into this JIRA, I would like discuss some bout this JIRA:

1. the SCMHeartbeatRequestProto has included a list of PipelineReport 
([https://github.com/apache/hadoop-ozone/blob/master/hadoop-hdds/container-service/src/main/proto/StorageContainerDatanodeProtocol.proto#L128])

2. HeartbeatEndpointTask is adding all pipeline reports into every heartbeat 
request 
([https://github.com/apache/hadoop-ozone/blob/master/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/states/endpoint/HeartbeatEndpointTask.java#L182])

3. The XceiverServerRatis seems to handle all raft groups together and every 
group has one pipelineId. Hence, every receiver server has all the pipeline 
reports. 
([https://github.com/apache/hadoop-ozone/blob/master/hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/XceiverServerRatis.java#L599])

So it seems that currently heartbeat has considers a bulk of pipelineIds from 
both sender and receiver sides. Do we have to make any changes to heartbeat 
reports then?

And also, what's the benefit for us to only report open pipelines in reports?

 

[~swagle] [~sammichen] [~xyao]

 

> Refactor heartbeat reports to report all the pipelines that are open
> --------------------------------------------------------------------
>
>                 Key: HDDS-1570
>                 URL: https://issues.apache.org/jira/browse/HDDS-1570
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: Ozone Datanode
>            Reporter: Siddharth Wagle
>            Assignee: Li Cheng
>            Priority: Major
>
> Presently the pipeline report only reports a single pipeline id.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to