[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16614401#comment-16614401
]
LiXin Ge commented on HDDS-369:
---
Hi [~elek], I have created HDDS-449 to add the null check as we discussed,
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16613310#comment-16613310
]
Elek, Marton commented on HDDS-369:
---
[~GeLiXin] You are right. For the unit tests we need to ensure that
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16612943#comment-16612943
]
LiXin Ge commented on HDDS-369:
---
Thanks for the commets [~elek].
Actually I find this doubts when I add unit
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16611796#comment-16611796
]
Elek, Marton commented on HDDS-369:
---
Thanks the commit [~hanishakoneru] and the good question [~GeLiXin].
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16607934#comment-16607934
]
LiXin Ge commented on HDDS-369:
---
Hi [~elek], sorry for the late review, is there have chance to introduce a
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603708#comment-16603708
]
Hudson commented on HDDS-369:
-
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14875 (See
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603653#comment-16603653
]
Hanisha Koneru commented on HDDS-369:
-
Committed to trunk.
Thanks [~elek] for working on this and
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16603535#comment-16603535
]
Hanisha Koneru commented on HDDS-369:
-
Thanks for updating the patch [~elek].
Patch v06 LGTM.
I have
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602136#comment-16602136
]
Hadoop QA commented on HDDS-369:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16602010#comment-16602010
]
Hadoop QA commented on HDDS-369:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16601951#comment-16601951
]
Elek, Marton commented on HDDS-369:
---
Yes, for some reason v005 has not been picked by jenkins. The last
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16599073#comment-16599073
]
Ajay Kumar commented on HDDS-369:
-
test failure seems related.
> Remove the containers of a dead node from
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598542#comment-16598542
]
genericqa commented on HDDS-369:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598472#comment-16598472
]
genericqa commented on HDDS-369:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597282#comment-16597282
]
Elek, Marton commented on HDDS-369:
---
Patch is rebased to the trunk.
> Remove the containers of a dead
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595381#comment-16595381
]
genericqa commented on HDDS-369:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16595295#comment-16595295
]
Elek, Marton commented on HDDS-369:
---
Thanks the review [~nandakumar131] and [~ajayydv]. I uploaded a new
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594120#comment-16594120
]
Ajay Kumar commented on HDDS-369:
-
[~elek] Patch LGTM. Minor nit:
Change log statement to parametrized
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594082#comment-16594082
]
Nanda kumar commented on HDDS-369:
--
[~elek], Thanks for working on this.
Instead of using
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591744#comment-16591744
]
genericqa commented on HDDS-369:
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16591655#comment-16591655
]
Elek, Marton commented on HDDS-369:
---
Thanks [~hanishakoneru] to check it. The shiny new patch is just
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16590694#comment-16590694
]
Hanisha Koneru commented on HDDS-369:
-
Thanks for working on this [~elek].
The patch LGTM overall. Can
[
https://issues.apache.org/jira/browse/HDDS-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16589206#comment-16589206
]
genericqa commented on HDDS-369:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
23 matches
Mail list logo
