[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598704#comment-16598704 ] genericqa commented on HDDS-379: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598611#comment-16598611 ] Elek, Marton commented on HDDS-379: --- Uploaded v5 patch where I create a base parent class for the cli to

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598571#comment-16598571 ] genericqa commented on HDDS-379: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16598420#comment-16598420 ] Elek, Marton commented on HDDS-379: --- Rename is reverted and the latest patch is uploaded. Thanks all the

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597970#comment-16597970 ] Anu Engineer commented on HDDS-379: --- bq. At cost of redundancy, i will re-iterate i am ok if you think

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597968#comment-16597968 ] Ajay Kumar commented on HDDS-379: - AFAIK wikipedia doesn't follow camlecase, neither does golang,

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597949#comment-16597949 ] Anu Engineer commented on HDDS-379: --- I do agree that there seems to be a case where some people have used

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597941#comment-16597941 ] Ajay Kumar commented on HDDS-379: - This is what quick search about word convention done shows: {quote}"a

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597933#comment-16597933 ] Anu Engineer commented on HDDS-379: --- {quote}End of the day as i said this is little subjective {quote} I

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597924#comment-16597924 ] Ajay Kumar commented on HDDS-379: - [~anu] {quote}unfortunately just because a word is a compound, we

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597886#comment-16597886 ] Anu Engineer commented on HDDS-379: --- unfortunately just because a word is a compound, we cannot camelcase

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597819#comment-16597819 ] Ajay Kumar commented on HDDS-379: - Not a language expert either so this looks like subjective suggestion. I

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597751#comment-16597751 ] Anu Engineer commented on HDDS-379: --- Not a language lawyer nor a native language speaker, But it looks

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16597335#comment-16597335 ] Elek, Marton commented on HDDS-379: --- Thank you the review [~ajayydv]. I fixed all of the suggested items:

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596851#comment-16596851 ] Ajay Kumar commented on HDDS-379: - [~elek] thanks for updating the patch. Patch looks good to me. Few

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596284#comment-16596284 ] Elek, Marton commented on HDDS-379: --- v002 addresses the findbug issue. > Simplify and improve the cli

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16596034#comment-16596034 ] Anu Engineer commented on HDDS-379: --- [~elek] Findbugs? > Simplify and improve the cli arg parsing of

[jira] [Commented] (HDDS-379) Simplify and improve the cli arg parsing of ozone scmcli

[ https://issues.apache.org/jira/browse/HDDS-379?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593812#comment-16593812 ] genericqa commented on HDDS-379: | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem ||